docs(changelog): add v2.1.2 release notes for #149, #150, #154#155
Merged
Conversation
coketaste
requested review from
Cemberk,
Rohan138,
gargrahul and
leconcio
as code owners
July 13, 2026 15:54
There was a problem hiding this comment.
Pull request overview
Adds v2.1.2 release notes to the project changelog to document three fixes already landed on develop (log error-pattern vs perf-metrics priority, sglang-disagg 2-node co-located proxy topology support + default split fix, and MAD_SECRETS_* redaction in logged Docker commands).
Changes:
- Add a new
2.1.2section dated 2026-07-13 with entries for #149, #150, and #154. - Document behavior changes for log scanning, SLURM launcher topology validation/default split, and secret redaction.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ### Changed | ||
|
|
||
| - **Log error-pattern match no longer overrides valid performance metrics** (#154, ROCM-27774): The post-run log scanner greps the entire run log, including a model's own generated stdout, so a generative benchmark (e.g. an LLM emitting `"ValueError:"` in a code sample) could flip an otherwise-successful run to `FAILURE`. Since the scan cannot distinguish framework/harness diagnostics from model output, valid extracted performance metrics now take priority: a pattern match no longer fails a run that produced valid perf data — the match is still surfaced (in yellow) for triage instead of silently failing. Status logic was extracted into a new `resolve_run_status()` helper (`execution/container_runner_helpers.py`) with unit tests. When no valid metrics exist, a pattern match still fails the run as before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
developahead ofmainChanges covered
has valid perf data
sglang-disaggSLURM launcher supports a co-located proxy on the first prefill node, lowering the minimum cluster size from 3 to 2 nodes (fix(slurm): support co-located proxy in sglang-disagg (min 2 nodes) #149)sglang-disaggdefault node split for the 2-node co-located topology, which previously computed an invalidyD=0decode count (fix(slurm): support co-located proxy in sglang-disagg (min 2 nodes) #149)MAD_SECRETS_*values (e.g. HF tokens) are now redacted in printed/raised Docker commands via a newredact_secrets()helper, preventing leakage into SLURM/run logs(fix(console): redact MAD_SECRETS_* values in printed/raised commands #150)
Test plan