Skip to content

Commit 66570bb

Browse files
update te wheel consumption
1 parent 8d6baaa commit 66570bb

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

.github/workflows/run_tests_against_package.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,8 @@ permissions:
7474
contents: read
7575
jobs:
7676
run:
77-
runs-on: ${{ inputs.cloud_runner != '' && inputs.cloud_runner || fromJson(format('["self-hosted", "{0}", "{1}"]', inputs.device_type, inputs.device_name)) }}
77+
runs-on: ${{ inputs.cloud_runner != '' && inputs.cloud_runner || (inputs.device_type == 'rocm' && fromJson('["self-hosted","linux-x86-64-4gpu-amd"]')) || fromJson(format('["self-hosted", "{0}", "{1}"]', inputs.device_type, inputs.device_name)) }}
78+
timeout-minutes: ${{ inputs.device_type == 'rocm' && 90 || 360 }}
7879
container:
7980
image: ${{ inputs.device_type == 'rocm' && 'ghcr.io/rocm/jax-base-ubu24.rocm720:latest' || format('gcr.io/tpu-prod-env-multipod/maxtext-unit-test-{0}:{1}', inputs.device_type == 'cpu' && 'tpu' || inputs.device_type, inputs.image_type) }}
8081
env:

.github/workflows/utils/install_te_rocm_wheel.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,8 @@ def try_download_from_te_rocm_wheels(repo: str, arch: str) -> bool:
9191
rel = json.loads(r.read().decode("utf-8"))
9292

9393
assets = rel.get("assets", [])
94-
name_re = re.compile(rf"^transformer_engine-.*-{arch}-cp312-cp312-linux_x86_64\.whl$")
94+
# Wheels published by this repo use the selector format: `-1.<arch>-...` (e.g. `-1.mi355-...`).
95+
name_re = re.compile(rf"^transformer_engine-.*-1\.{arch}-cp312-cp312-linux_x86_64\.whl$")
9596
hit = next((a for a in assets if name_re.match(a.get("name", ""))), None)
9697
if not hit:
9798
return False

0 commit comments

Comments
 (0)