Commit 7ae4abf
committed
Address PR review comments for layout mapping
Replace hardcoded ROCMLIR_TO_MIOPEN_LAYOUT dict with algorithmic
best-effort conversion: normalize spatial dims (0->H, 1->W), drop
group dim (G), then classify by innermost dimension (channel-first
-> NCHW, channel-last -> NHWC).
- Add "best effort mapping" disclaimer (umangyadav)
- Warn on group convolutions G>1 where dropping G is lossy (dhernandez0)
- Handle K defensively in heuristic (dhernandez0)
- Warn on unrecognised layouts instead of silent passthrough (cursor)
- Run yapf formatting
Made-with: Cursor1 parent ceb8c23 commit 7ae4abf
1 file changed
Lines changed: 3 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
765 | 765 | | |
766 | 766 | | |
767 | 767 | | |
768 | | - | |
769 | | - | |
770 | | - | |
771 | | - | |
772 | | - | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
773 | 771 | | |
774 | 772 | | |
775 | 773 | | |
| |||
0 commit comments