test: fix clippy warnings in e2e-cucumber and exclude from workspace test hook

Signed-off-by: fredespi <fredrik.espinoza@gmail.com>

Author: fredespi

.pre-commit-config.yaml

@@ -116,7 +116,7 @@ repos:
         groups: [local-tools] # runs in the dedicated `clippy` CI job
       - id: cargo-test
         name: cargo test
-        entry: cargo test --workspace --all-targets
+        entry: cargo test --workspace --all-targets --exclude e2e-cucumber
         language: system
         types: [rust]
         pass_filenames: false

tests/e2e-cucumber/src/mock_server.rs

@@ -28,7 +28,7 @@ impl std::fmt::Debug for MockServer {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         f.debug_struct("MockServer")
             .field("addr", &self.addr)
-            .finish()
+            .finish_non_exhaustive()
     }
 }
 
@@ -71,7 +71,7 @@ impl MockServer {
         format!("http://{}/v1", self.addr)
     }
 
-    pub fn port(&self) -> u16 {
+    pub const fn port(&self) -> u16 {
         self.addr.port()
     }
 

tests/e2e-cucumber/src/report.rs

@@ -58,7 +58,7 @@ struct Stats {
 }
 
 impl Stats {
-    fn new() -> Self {
+    const fn new() -> Self {
         Self {
             total: 0,
             passed: 0,
@@ -99,7 +99,7 @@ impl Stats {
         )
     }
 
-    fn status_text(&self) -> &'static str {
+    const fn status_text(&self) -> &'static str {
         if self.failed > 0 {
             "FAIL"
         } else if self.total == 0 {
@@ -110,7 +110,7 @@ impl Stats {
     }
 }
 
-fn scenario_status(el: &Element) -> &str {
+fn scenario_status(el: &Element) -> &'static str {
     for s in &el.steps {
         if s.result.status == "failed" {
             return "failed";
@@ -159,7 +159,7 @@ pub fn generate(json_path: &Path, html_path: &Path) -> std::io::Result<()> {
         .map(|d| {
             let secs = d.as_secs();
             let days = secs / 86400;
-            let y = 1970 + (days * 400 / 146097);
+            let y = 1970 + (days * 400 / 146_097);
             format!("{y}-xx-xx (epoch {secs})")
         })
         .unwrap_or_default();
@@ -317,46 +317,46 @@ pub fn generate(json_path: &Path, html_path: &Path) -> std::io::Result<()> {
                 "<details class=\"scenario\">\n<summary class=\"scenario-row\">\n"
             )
             .unwrap();
-            write!(
+            writeln!(
                 html,
-                "  <span class=\"badge {badge_class}\">{badge_text}</span>\n"
+                "  <span class=\"badge {badge_class}\">{badge_text}</span>"
             )
             .unwrap();
-            write!(
+            writeln!(
                 html,
-                "  <span class=\"scenario-name\">{}</span>\n",
+                "  <span class=\"scenario-name\">{}</span>",
                 escape(&scenario.name)
             )
             .unwrap();
             for tag in &scenario.tags {
-                write!(html, "  <span class=\"tag\">{}</span>\n", escape(&tag.name)).unwrap();
+                writeln!(html, "  <span class=\"tag\">{}</span>", escape(&tag.name)).unwrap();
             }
-            write!(html, "  <span class=\"elapsed\">{dur_ms}ms</span>\n").unwrap();
-            write!(html, "</summary>\n").unwrap();
+            writeln!(html, "  <span class=\"elapsed\">{dur_ms}ms</span>").unwrap();
+            writeln!(html, "</summary>").unwrap();
 
-            write!(html, "<div class=\"steps\">\n").unwrap();
+            writeln!(html, "<div class=\"steps\">").unwrap();
             for step in &scenario.steps {
                 let (icon, icon_class) = match step.result.status.as_str() {
                     "passed" => ("&#x2714;", "pass"),
                     "failed" => ("&#x2718;", "fail"),
                     _ => ("&#x25CB;", ""),
                 };
                 let step_ms = step.result.duration / 1_000_000;
-                write!(
+                writeln!(
                     html,
-                    "  <div class=\"step\"><span class=\"step-icon {icon_class}\">{icon}</span><span class=\"step-keyword\">{}</span>{}<span class=\"step-duration\">{step_ms}ms</span></div>\n",
+                    "  <div class=\"step\"><span class=\"step-icon {icon_class}\">{icon}</span><span class=\"step-keyword\">{}</span>{}<span class=\"step-duration\">{step_ms}ms</span></div>",
                     escape(&step.keyword),
                     escape(&step.name),
                 ).unwrap();
 
                 if let Some(err) = &step.result.error_message {
-                    write!(html, "  <div class=\"error-box\">{}</div>\n", escape(err)).unwrap();
+                    writeln!(html, "  <div class=\"error-box\">{}</div>", escape(err)).unwrap();
                 }
             }
             write!(html, "</div>\n</details>\n").unwrap();
         }
 
-        write!(html, "</div>\n").unwrap();
+        writeln!(html, "</div>").unwrap();
     }
 
     write!(html, "</div>\n</body>\n</html>\n").unwrap();
@@ -373,10 +373,10 @@ fn write_stats_table(html: &mut String, title: &str, rows: &[(String, &Stats)])
     )
     .unwrap();
     for (label, stats) in rows {
-        write!(
+        writeln!(
             html,
             "<tr><td><a href=\"#\">{}</a></td><td class=\"num\">{}</td><td class=\"num\">{}</td>\
-             <td class=\"num\">{}</td><td class=\"num\">{}</td><td class=\"num\">{}</td><td>{}</td></tr>\n",
+             <td class=\"num\">{}</td><td class=\"num\">{}</td><td class=\"num\">{}</td><td>{}</td></tr>",
             escape(label),
             stats.total,
             stats.passed,
@@ -386,7 +386,7 @@ fn write_stats_table(html: &mut String, title: &str, rows: &[(String, &Stats)])
             stats.bar_html(),
         ).unwrap();
     }
-    write!(html, "</table>\n").unwrap();
+    writeln!(html, "</table>").unwrap();
 }
 
 fn escape(s: &str) -> String {