Add SOMA IPC examples#481
Open
adeljo-amd wants to merge 1 commit into
Open
Conversation
zichguan-amd
left a comment
zichguan-amd
left a comment
Collaborator
There was a problem hiding this comment.
LGTM with minor details
Comment on lines
+6
to
+9
| if ! lsmod | grep -q "^amdgpu"; then | ||
| echo "Skipping: amdgpu-dkms driver not loaded." | ||
| exit 77 | ||
| fi |
Collaborator
There was a problem hiding this comment.
Is there any reason this is different than the device_pointer amdgpu check?
Comment on lines
+46
to
+47
| constexpr const char* fifoPath = "/tmp/hip_ipc_devptr_fifo"; | ||
| constexpr const char* doneFifoPath = "/tmp/hip_ipc_devptr_done_fifo"; |
Collaborator
There was a problem hiding this comment.
These are not unlinked for cleanup, can we mirror shareable_handle on this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add the examples from the following snippets to rocm-examples https://rocm.docs.amd.com/projects/HIP/en/latest/how-to/hip_runtime_api/memory_management/stream_ordered_allocator.html#interprocess-memory-handling
These examples are not added to the CI for 2 reasons:
Technical Details
Test Plan
Test Result
Added/Updated documentation?
Included Visual Studio files?
Submission Checklist