Commit f0ee75d
[Conv] Remove duplicate GetCKMaxWorkspaceSize declaration in 3D grouped-wrw solver
ConvHipImplicitGemm3DGroupWrwXdlops declared GetCKMaxWorkspaceSize twice:
a templated helper (per-dtype alpha/beta dispatch) plus a same-name
non-template dispatcher, which read as an accidental duplicate (and mixed
std::size_t / size_t).
Mirror the sibling CheckCKApplicability pattern in the same class: keep the
templated helper only and inline the dtype switch at the sole caller
(GetWorkspaceSize), exactly as IsApplicable does for CheckCKApplicability.
This removes the redundant member and the confusing declaration pair.
Behavior is unchanged.
Reported-by: Sree
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>1 parent f42cb0d commit f0ee75d
2 files changed
Lines changed: 8 additions & 15 deletions
File tree
- projects/miopen/src
- include/miopen/conv
- solver/conv
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4645 | 4645 | | |
4646 | 4646 | | |
4647 | 4647 | | |
4648 | | - | |
4649 | | - | |
| 4648 | + | |
4650 | 4649 | | |
4651 | 4650 | | |
4652 | 4651 | | |
| |||
Lines changed: 7 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
557 | 557 | | |
558 | 558 | | |
559 | 559 | | |
560 | | - | |
| 560 | + | |
| 561 | + | |
561 | 562 | | |
| 563 | + | |
562 | 564 | | |
563 | 565 | | |
564 | 566 | | |
565 | | - | |
566 | | - | |
567 | | - | |
568 | | - | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
569 | 571 | | |
570 | 572 | | |
571 | 573 | | |
572 | 574 | | |
573 | 575 | | |
574 | 576 | | |
575 | 577 | | |
576 | | - | |
577 | | - | |
578 | | - | |
579 | | - | |
580 | | - | |
581 | | - | |
582 | | - | |
583 | | - | |
584 | 578 | | |
585 | 579 | | |
586 | 580 | | |
| |||
0 commit comments