[hipDNN] ALMIOPEN-1869 Install Python pytest files into share/hipdnn/tests/python#7869
Open
tvy-amd wants to merge 1 commit into
Open
[hipDNN] ALMIOPEN-1869 Install Python pytest files into share/hipdnn/tests/python#7869tvy-amd wants to merge 1 commit into
tvy-amd wants to merge 1 commit into
Conversation
Install hipdnn_frontend/test/*.py into share/hipdnn/tests/python in the non-SKBUILD path so the pytest suite is available alongside the built Python module. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
tvy-amd
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #7869 +/- ##
===========================================
- Coverage 62.06% 62.06% -0.00%
===========================================
Files 2085 2085
Lines 357573 357573
Branches 54060 54060
===========================================
- Hits 221918 221914 -4
- Misses 116866 116868 +2
- Partials 18789 18791 +2
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
tvy-amd
added
skip-therockci
tvy-amd
commented
May 29, 2026
| install(TARGETS hipdnn_frontend_python DESTINATION "${_staging}") | ||
| install(FILES "${CMAKE_CURRENT_SOURCE_DIR}/hipdnn_frontend/__init__.py" | ||
| DESTINATION "${_staging}") | ||
| install(DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/hipdnn_frontend/test/" |
Contributor
Author
There was a problem hiding this comment.
https://github.com/ROCm/rocm-libraries/tree/develop/projects/hipdnn/python/hipdnn_frontend/test
There does exist a test_engine_id_overloads.py in here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hipdnn_frontend/test/*.pyintoshare/hipdnn/tests/pythonin the non-SKBUILD path so the pytest suite ships alongside the built Python module.Risk
Low. Installing existing .py files to the install folder.
Test plan
share/hipdnn/tests/python/*.pypopulated in install prefix.🤖 Generated with Claude Code