[hipDNN] Fix -Werror=unused-variable errors breaking superbuild#7907
Closed
AnaghaRaoAMD wants to merge 1 commit into
Closed
[hipDNN] Fix -Werror=unused-variable errors breaking superbuild#7907AnaghaRaoAMD wants to merge 1 commit into
AnaghaRaoAMD wants to merge 1 commit into
Conversation
Replace `auto _ = expr()` with `(void)expr()` to properly discard return values without triggering unused variable warnings under -Werror. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
AnaghaRaoAMD
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #7907 +/- ##
========================================
Coverage 62.06% 62.06%
========================================
Files 2088 2088
Lines 358353 358353
Branches 54207 54207
========================================
Hits 222379 222379
Misses 117148 117148
Partials 18826 18826
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Replace
auto _ = expr()with(void)expr()to properly discard return values without triggering unused variable warnings under -Werror.The
auto _pattern was introduced in PR #7279 (commit 9da9c82) to clarify that thedlerror()return value is intentionally discarded. However, GCC treats_as a regular variable and raises-Wunused-variable, which becomes a build failure under-Werror. Clang treats _ as a conventional discard name and does not warn, which is why CI (using ROCm clang) did not catch this.The
(void)cast is the standard, portable C/C++ idiom for intentionally discarding a return value and works under both GCC and Clang.Technical Details
Test Plan
Test Result
Submission Checklist