Skip to content

[hipDNN] Fix -Werror=unused-variable errors breaking superbuild #7907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AnaghaRaoAMD wants to merge 1 commit into from
Closed

[hipDNN] Fix -Werror=unused-variable errors breaking superbuild #7907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions projects/hipdnn/backend/src/HipdnnBackend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ HIPDNN_BACKEND_EXPORT void hipdnnGetLastErrorString(char* message, size_t maxSiz
LOG_API_ENTRY("message_ptr={:p}, maxSize={}", static_cast<void*>(message), maxSize);
// Ignore status since API doesn't return it.
// We still want to catch and log if the user provides incorrect parameters.
auto _ = hipdnn_backend::tryCatch([&, apiName = __func__] {
(void)hipdnn_backend::tryCatch([&, apiName = __func__] {
throwIfNull(message);

if(maxSize == 0)
Expand All @@ -431,7 +431,7 @@ HIPDNN_BACKEND_EXPORT void hipdnnPeekLastErrorString_ext(char* message, size_t m
LOG_API_ENTRY("message_ptr={:p}, maxSize={}", static_cast<void*>(message), maxSize);
// Ignore status since API doesn't return it.
// We still want to catch and log if the user provides incorrect parameters.
auto _ = hipdnn_backend::tryCatch([&, apiName = __func__] {
(void)hipdnn_backend::tryCatch([&, apiName = __func__] {
throwIfNull(message);

if(maxSize == 0)
Expand Down
4 changes: 2 additions & 2 deletions projects/hipdnn/data_sdk/include/hipdnn_data_sdk/utilities/PlatformUtils.linux.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,13 @@ inline void closeLibrary(SharedLibraryHandle handle)

inline void* getSymbol(SharedLibraryHandle handle, const char* symbolName)
{
auto _ = dlerror();
(void)dlerror();
return dlsym(handle, symbolName);
}

inline std::filesystem::path getLoadedLibraryDirectoryForSymbol(const char* symbolName)
{
auto _ = dlerror();
(void)dlerror();
void* symbol = dlsym(RTLD_DEFAULT, symbolName);
const char* error = dlerror();
if(error != nullptr)
Expand Down
Loading