test: [rocWMMA] fix: Catch launch errors in regression test#8862
Merged
Conversation
bsyrowik
changed the title
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
bsyrowik
changed the title
bsyrowik
changed the title
|
Overriding, Math CI test hang looks unrelated to this and is a known issue to component team. |
assistant-librarian Bot
pushed a commit
to ROCm/rocWMMA
that referenced
this pull request
Jul 7, 2026
test: [rocWMMA] fix: Catch launch errors in regression test (#8862) ## Motivation If the device code we've loaded is for an invalid device we will never detect that, and will silently continue to compare invalid values without running the kernel. Should make error signature for JIRA ID: ROCM-27254 more clear. ## Technical Details This change catches that situation and will error out with a useful message instead of showing that the values we have are invalid. ## Test Plan Manual test. CI flow. ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If the device code we've loaded is for an invalid device we will never detect that, and will silently continue to compare invalid values without running the kernel.
Should make error signature for
JIRA ID: ROCM-27254
more clear.
Technical Details
This change catches that situation and will error out with a useful message instead of showing that the values we have are invalid.
Test Plan
Manual test.
CI flow.
Test Result
Submission Checklist