Skip to content

Revert "[rocThrust] Change default SQLite3 to system package and bump SQLite3 version to 3.51.3"#8890

Merged
arjun-raj-kuppala merged 1 commit into
developfrom
revert-5899-users/stanleytsang-amd/rocthrust-sqlite-dep-therock
Jun 29, 2026
Merged

Revert "[rocThrust] Change default SQLite3 to system package and bump SQLite3 version to 3.51.3"#8890
arjun-raj-kuppala merged 1 commit into
developfrom
revert-5899-users/stanleytsang-amd/rocthrust-sqlite-dep-therock

Conversation

@amd-chiranjeevi

Copy link
Copy Markdown
Contributor

Reverts PR: #5899
Fixes Issue: #8889

@therock-pr-bot

therock-pr-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass
📝 PR Title/Description ❌ Fail Error: Title is too long (96 characters).
Expected: at most 80 characters.
Desired format: type(optional-scope): short description
───
Error: Title does not follow Conventional Commits style.
Expected: start with a valid type (feat, fix, docs, …).
Desired format: type(optional-scope): short description
Forbidden Files ✅ Pass
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass
🚫 Draft PR 🔜 To Be Enabled
🚩 Feature Flag 🔜 To Be Enabled
📊 Code Coverage 🔜 To Be Enabled

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (76.92%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8890      +/-   ##
===========================================
+ Coverage    71.34%   71.37%   +0.03%     
===========================================
  Files         2613     2614       +1     
  Lines       409004   409511     +507     
  Branches     61116    61171      +55     
===========================================
+ Hits        291781   292285     +504     
  Misses       95820    95820              
- Partials     21403    21406       +3     
Flag Coverage Δ *Carryforward flag
TensileLite 76.99% <ø> (ø) Carriedforward from 2a89753
hipBLAS 90.81% <ø> (ø) Carriedforward from 2a89753
hipBLASLt 41.36% <ø> (ø) Carriedforward from 2a89753
hipCUB 82.68% <ø> (ø) Carriedforward from 2a89753
hipDNN 86.79% <ø> (ø) Carriedforward from 2a89753
hipFFT 50.17% <ø> (ø) Carriedforward from 2a89753
hipRAND 76.12% <ø> (ø) Carriedforward from 2a89753
hipSOLVER 69.18% <ø> (ø) Carriedforward from 2a89753
hipSPARSE 86.55% <ø> (ø) Carriedforward from 2a89753
rocBLAS 48.08% <ø> (ø) Carriedforward from 2a89753
rocFFT 46.30% <ø> (ø) Carriedforward from 2a89753
rocRAND 57.07% <ø> (ø) Carriedforward from 2a89753
rocSOLVER 76.92% <ø> (ø) Carriedforward from 2a89753
rocSPARSE 72.37% <ø> (ø) Carriedforward from 2a89753
rocThrust 91.45% <ø> (+0.10%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.
see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@spolifroni-amd spolifroni-amd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is making changes to previous versions of rocThrust (for 7.14 and 7.12)

Add a changelog entry for the version of rocThrust where this change will be included and undo the changes to the previous versions.

Thanks!

@arjun-raj-kuppala arjun-raj-kuppala self-requested a review June 29, 2026 16:01

@arjun-raj-kuppala arjun-raj-kuppala left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking bump prs ci as mentioned in this revert PR.

@arjun-raj-kuppala arjun-raj-kuppala merged commit f7081db into develop Jun 29, 2026
39 of 44 checks passed
@arjun-raj-kuppala arjun-raj-kuppala deleted the revert-5899-users/stanleytsang-amd/rocthrust-sqlite-dep-therock branch June 29, 2026 16:05
@amd-chiranjeevi amd-chiranjeevi added the bump-pr-revert reverted pr which were created to unblock bump pr in throck label Jun 30, 2026
JP-Fernando pushed a commit that referenced this pull request Jul 1, 2026
… SQLite3 version to 3.51.3" (#8890)

Reverts PR: #5899
Fixes Issue: #8889
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bump-pr-revert reverted pr which were created to unblock bump pr in throck documentation organization: ROCm project: rocthrust

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants