fix(tensilelite): Accept .dat.zlib in --use-cache existence check#8892
Merged
archana-ramalingam merged 2 commits intoJul 1, 2026
Merged
Conversation
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Codecov Report❌ Patch coverage is
❌ Your project status has failed because the head coverage (76.92%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #8892 +/- ##
===========================================
- Coverage 71.27% 71.27% -0.00%
===========================================
Files 2613 2613
Lines 409506 409509 +3
Branches 61210 61210
===========================================
Hits 291868 291868
- Misses 96183 96186 +3
Partials 21455 21455
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
archana-ramalingam
force-pushed
the
users/aramalin/fix-dat-zlib-existence-check
branch
from
35c8f5e to
3787c94
Compare
…HPBLAS-3508] PR #8294 changed writeMsgPack() to produce .dat.zlib files but missed updating the Python existence check in BenchmarkProblems.py. The C++ client already probes for .zlib automatically (fileToMsgObject tries filename + ".zlib" first), so the fix widens only the Python check to accept both .dat and .dat.zlib on disk. Without this fix, all --use-cache benchmark tests FATAL with "cache.yaml refers to a library file that no longer exists" when LibraryFormat=msgpack. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
archana-ramalingam
force-pushed
the
users/aramalin/fix-dat-zlib-existence-check
branch
from
65c402b to
0f87fd5
Compare
talumbau
approved these changes
Jun 30, 2026
talumbau
left a comment
talumbau
left a comment
Collaborator
There was a problem hiding this comment.
thanks for the quick fix!
archana-ramalingam
deleted the
users/aramalin/fix-dat-zlib-existence-check
branch
JP-Fernando
pushed a commit
that referenced
this pull request
Jul 1, 2026
) ## Motivation PR #8294 changed `writeMsgPack()` to compress library catalogs with zlib, producing `.dat.zlib` files instead of `.dat`. The C++ runtime's `fileToMsgObject()` was updated to probe for `.zlib` automatically, but the Python `--use-cache` existence check in `BenchmarkProblems.py` was missed — it still checks only for `.dat`, causing all `--use-cache` benchmark tests to FATAL when `LibraryFormat=msgpack`. ## Technical Details Widen the `os.path.isfile()` existence check to accept both `.dat` and `.dat.zlib` on disk. The path passed to the C++ client stays as `.dat`, matching the C++ probe convention from PR #8294 where `fileToMsgObject()` tries `filename + ".zlib"` before the base file. ## Test Plan - [x] Emulation CI: common tests pass with `LibraryFormat=msgpack` - [x] No change to `tensileLibraryFile()` or `writeClientConfigIni` — C++ client probe convention preserved - [x] Jenkins `tox -e py3` (yaml format, unaffected path) ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. JIRA ID: AIHPBLAS-3508 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR #8294 changed
writeMsgPack()to compress library catalogs with zlib, producing.dat.zlibfiles instead of.dat. The C++ runtime'sfileToMsgObject()was updated to probe for.zlibautomatically, but the Python--use-cacheexistence check inBenchmarkProblems.pywas missed — it still checks only for.dat, causing all--use-cachebenchmark tests to FATAL whenLibraryFormat=msgpack.Technical Details
Widen the
os.path.isfile()existence check to accept both.datand.dat.zlibon disk. The path passed to the C++ client stays as.dat, matching the C++ probe convention from PR #8294 wherefileToMsgObject()triesfilename + ".zlib"before the base file.Test Plan
LibraryFormat=msgpacktensileLibraryFile()orwriteClientConfigIni— C++ client probe convention preservedtox -e py3(yaml format, unaffected path)Submission Checklist
JIRA ID: AIHPBLAS-3508