[rocprofiler-compute] fix crash of unit tests of attach detach gfx1151#5928
Open
ywang103-amd wants to merge 2 commits intousers/vedithal-amd/rocprofiler-compute-7.14-devfrom
Open
Conversation
…tests and forcing sdk output to csv
…sers/ywang103/fix-crash-attach-detach-gfx1151
xuchen-amd
changed the title
vedithal-amd
requested changes
May 8, 2026
Contributor
vedithal-amd
left a comment
vedithal-amd
left a comment
There was a problem hiding this comment.
I dont think this is the right approach, we need to understand why rocprofiler-sdk on develop branch is not able to write rocpd successfully in attach/detach mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixed crashes of tests of live attach/detach on gfx1151, which are caused by unsupported pc sampling and some issues of rocpd on the side of rocprofiler-sdk. It forces output as csv for rocprof and also skipped all tests that require pc sampling on gfx1151. PC sampling is not yet supported on gfx1151
Technical Details
JIRA ID
ROCM-23493
Test Plan
Test Result
Submission Checklist