[rdc] Add RDC_FI_AFID field decoding AFID + severity from the CPER ring#7728
Closed
brichang wants to merge 1 commit into
Closed
[rdc] Add RDC_FI_AFID field decoding AFID + severity from the CPER ring#7728brichang wants to merge 1 commit into
brichang wants to merge 1 commit into
Conversation
Add a new RDC field RDC_FI_AFID that reads CPER records directly from the driver via amdsmi_get_gpu_cper_entries() and decodes the AMD Field ID(s) with amdsmi_get_afids_from_cper(). The field is reported as a STRING of comma-separated <afid>:<severity> pairs (severity one of FATAL / CORRECTED / UNCORRECTED), or N/A when the ring is empty. This lets users read AFIDs as a normal RDC field (rdci dmon -e AFID) without first configuring a CPER dump folder via amd-smi, and intentionally omits the service-action-guide text so only the AFID number and severity are surfaced. Signed-off-by: Brian Chang <brichang@amd.com>
Contributor
|
superseded by #8527 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new RDC field
RDC_FI_AFID(id 680, labelAFID) that surfaces the AMD Field ID(s) and severity of the GPU's RAS CPER records as a regular RDC field.get_afid()reads CPER records straight from the driver viaamdsmi_get_gpu_cper_entries()and decodes the AFID(s) of each record withamdsmi_get_afids_from_cper().STRINGof comma-separated<afid>:<severity>pairs, where severity is one ofFATAL/CORRECTED/UNCORRECTED, orN/Awhen the ring has no matching records.rdc_field.data(name/label/validity) and inRdcSmiLib's telemetry field list, so it works like any other field (e.g.rdci dmon -e AFID).Motivation:
amd-smi ras --cper --folder ....Test plan
rdci dmon -llists680 RDC_FI_AFID : Decoded AFID(s) and severity from CPER.rdci dmon -i 0 -e 680returned24:CORRECTED,...,25:FATAL,..., matchingamd-smi ras --cperoutput for the same GPU.amdgpuras; new CPER records appeared in the driver ring and the AFID field immediately reflected the new24:CORRECTEDentries.Note: reading the CPER ring requires debugfs (
/sys/kernel/debug/dri/<n>/amdgpu_ring_cper) to be accessible to the process; otherwise the field returnsN/A.Signed-off-by: Brian Chang brichang@amd.com
Made with Cursor