Update rocm xformers dockerfile#81
Open
sammysun0711 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR aim to fix xformers build issue on ROCm platform with composable kernel support.
XFORMERS_CK_FLASH_ATTN=1and useHIP_ARCHITECTUREinstead ofHIP_ARCHITECTURESto meet following condition to enable composable kernel during docker build:xformers/setup.py
Lines 576 to 580 in c9911ff
BTW, it seems current
setup.pycan only support compilation on the single target gfx architecture due to different compilation option:xformers/setup.py
Lines 606 to 613 in c9911ff
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.