Skip to content

Commit 9f2cd88

Browse files
committed
Reorder setup wizard to prepare PDK before tools
1 parent 7e1d457 commit 9f2cd88

1 file changed

Lines changed: 15 additions & 9 deletions

File tree

app/ui/setup_tab.py

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,12 @@ class SetupTab(QWidget):
3434
settings_updated = Signal(object)
3535
send_status = Signal(str)
3636

37+
STEP_REVIEW = 0
38+
STEP_PDK = 1
39+
STEP_TOOLS = 2
40+
STEP_APPLY = 3
41+
STEP_VALIDATE = 4
42+
3743
def __init__(self, settings: AppSettings) -> None:
3844
super().__init__()
3945
self.settings = settings
@@ -43,8 +49,8 @@ def __init__(self, settings: AppSettings) -> None:
4349
self.runner = CommandRunner()
4450
self._wizard_steps = [
4551
pick(self.lang, "1. Revisar sistema", "1. Review system"),
46-
pick(self.lang, "2. Instalar tools", "2. Install tools"),
47-
pick(self.lang, "3. Preparar PDK", "3. Prepare PDK"),
52+
pick(self.lang, "2. Preparar PDK", "2. Prepare PDK"),
53+
pick(self.lang, "3. Instalar tools", "3. Install tools"),
4854
pick(self.lang, "4. Aplicar rutas", "4. Apply paths"),
4955
pick(self.lang, "5. Validar", "5. Validate"),
5056
]
@@ -191,8 +197,8 @@ def _build_ui(self) -> None:
191197
layout.addLayout(nav)
192198

193199
self.step_stack.addWidget(self._build_review_page())
194-
self.step_stack.addWidget(self._build_install_page())
195200
self.step_stack.addWidget(self._build_pdk_page())
201+
self.step_stack.addWidget(self._build_install_page())
196202
self.step_stack.addWidget(self._build_apply_page())
197203
self.step_stack.addWidget(self._build_validate_page())
198204

@@ -616,7 +622,7 @@ def apply_selected_pdk_candidate(self) -> None:
616622
f"The detected PDK at {sky130a_path} was adopted.\n",
617623
)
618624
)
619-
self._set_step(3)
625+
self._set_step(self.STEP_APPLY)
620626
self._finish_activity(True, pick(self.lang, "PDK listo para usar", "PDK ready to use"))
621627
return
622628
self._finish_activity(True, pick(self.lang, "El PDK ya estaba aplicado", "The PDK was already applied"))
@@ -637,7 +643,7 @@ def install_managed_pdk(self) -> None:
637643
self.send_status.emit(pick(self.lang, "PDK gestionado listo", "Managed PDK ready"))
638644
self.refresh_detection()
639645
self.refresh_validation()
640-
self._set_step(3)
646+
self._set_step(self.STEP_APPLY)
641647
self._finish_activity(True, pick(self.lang, "PDK gestionado instalado", "Managed PDK installed"))
642648
return
643649
self.log.append(pick(self.lang, f"{result.message}\n", f"{result.message}\n"))
@@ -787,7 +793,7 @@ def install_environment(self) -> None:
787793
)
788794
)
789795
self.send_status.emit(pick(self.lang, "Instalación en progreso", "Installation in progress"))
790-
self._set_step(1)
796+
self._set_step(self.STEP_TOOLS)
791797
self._runner_action = "install_tools"
792798
self.runner.run(CommandSpec(command=self.setup_mgr.installer_command()))
793799

@@ -821,7 +827,7 @@ def _on_finished(self, code: int, status: str) -> None:
821827
self.send_status.emit(pick(self.lang, "Build de PDK listo", "PDK build ready"))
822828
self.refresh_detection()
823829
self.refresh_validation()
824-
self._set_step(3)
830+
self._set_step(self.STEP_APPLY)
825831
self._finish_activity(True, pick(self.lang, "Build de PDK listo", "PDK build ready"))
826832
return
827833

@@ -837,7 +843,7 @@ def _on_finished(self, code: int, status: str) -> None:
837843
self.refresh_detection()
838844
self.refresh_validation()
839845
self._apply_detected_defaults(automatic=True)
840-
self._set_step(3)
846+
self._set_step(self.STEP_APPLY)
841847
self._finish_activity(True, pick(self.lang, "Bundle PDK listo", "PDK bundle ready"))
842848
return
843849

@@ -909,7 +915,7 @@ def _apply_detected_defaults(self, automatic: bool) -> None:
909915
)
910916
)
911917
self.send_status.emit(pick(self.lang, "Rutas detectadas aplicadas", "Detected paths applied"))
912-
self._set_step(4)
918+
self._set_step(self.STEP_VALIDATE)
913919
self._finish_activity(True, pick(self.lang, "Rutas aplicadas", "Paths applied"))
914920
return
915921

0 commit comments

Comments
 (0)