sysinfo.cpp: Relax TSC calibration constraints#17909
Conversation
| return 0; | ||
| } | ||
|
|
||
| if (freq.QuadPart <= 50'000) |
There was a problem hiding this comment.
I don't think this is possible for any known TSC. 50KHz cycle counter is way too coarse for a high precision timer.
For reference the archaic RTC already has 32k resolution.
Let's gather data for now though before we decide which values to use for tuning.
There was a problem hiding this comment.
This isn't about possible motherboards or CPUs or operating system settings, it's the constraint for the function itself.
There was a problem hiding this comment.
I get that, but why 50k then? Why isn't any non-zero value legal?
There was a problem hiding this comment.
Looking at the other explanation, it makes sense to have a lower bound. Let's at least make it a named constexpr like min_supported_tsc_frequency instead of magic constants.
|
Is this dead? |
4 participants
Maybe fixes #17575