Skip to content

move preferences to a separate lib and use as a dependency + update d… #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ishan09811 merged 2 commits into from
May 9, 2026
Merged

move preferences to a separate lib and use as a dependency + update d… #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c2d6e0
move preferences to a separate lib and use as a dependency + update d…
Ishan09811 May 8, 2026
f63a467
update missing imports
Ishan09811 May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,5 +109,5 @@ dependencies {
implementation(libs.coil.compose)
implementation(libs.squareup.okhttp3)
implementation(libs.androidx.documentfile)
implementation(libs.com.github.ishan09811.materialswitch)
implementation(libs.compose.preferences)
}
2 changes: 1 addition & 1 deletion app/src/main/java/net/rpcsx/ui/channels/UpdateChannelListScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.unit.dp
import com.github.ishan09811.compose_preferences.core.DeletableListItem
import net.rpcsx.R
import net.rpcsx.ui.settings.components.core.DeletableListItem


@Composable
Expand Down
5 changes: 2 additions & 3 deletions app/src/main/java/net/rpcsx/ui/channels/UpdateChannelsScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,9 @@ import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.unit.dp
import com.github.ishan09811.compose_preferences.core.PreferenceSubtitle
import com.github.ishan09811.compose_preferences.preference.RegularPreference
import net.rpcsx.R
import net.rpcsx.ui.settings.components.core.PreferenceSubtitle
import net.rpcsx.ui.settings.components.preference.RegularPreference

const val DefaultGpuDriverChannel = "https://github.com/K11MCH1/AdrenoToolsDrivers"
const val ReleaseUiChannel = "https://github.com/RPCSX/rpcsx-ui-android"
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/net/rpcsx/ui/drivers/GpuDriversScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,14 @@ import androidx.compose.ui.res.painterResource
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.font.FontWeight
import androidx.compose.ui.unit.dp
import com.github.ishan09811.compose_preferences.core.DeletableListItem
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext
import net.rpcsx.R
import net.rpcsx.RPCSX
import net.rpcsx.dialogs.AlertDialogQueue
import net.rpcsx.ui.channels.DefaultGpuDriverChannel
import net.rpcsx.ui.settings.components.core.DeletableListItem
import net.rpcsx.utils.DriversFetcher
import net.rpcsx.utils.GeneralSettings
import net.rpcsx.utils.GeneralSettings.string
Expand Down
16 changes: 8 additions & 8 deletions app/src/main/java/net/rpcsx/ui/settings/SettingsScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,14 @@ import androidx.compose.ui.tooling.preview.Preview
import androidx.compose.ui.unit.dp
import androidx.compose.ui.unit.sp
import androidx.documentfile.provider.DocumentFile
import com.github.ishan09811.compose_preferences.core.PreferenceHeader
import com.github.ishan09811.compose_preferences.core.PreferenceIcon
import com.github.ishan09811.compose_preferences.core.PreferenceValue
import com.github.ishan09811.compose_preferences.preference.HomePreference
import com.github.ishan09811.compose_preferences.preference.RegularPreference
import com.github.ishan09811.compose_preferences.preference.SingleSelectionDialog
import com.github.ishan09811.compose_preferences.preference.SliderPreference
import com.github.ishan09811.compose_preferences.preference.SwitchPreference
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext
Expand All @@ -84,14 +92,6 @@ import net.rpcsx.UserRepository
import net.rpcsx.dialogs.AlertDialogQueue
import net.rpcsx.provider.AppDataDocumentProvider
import net.rpcsx.ui.common.ComposePreview
import net.rpcsx.ui.settings.components.core.PreferenceHeader
import net.rpcsx.ui.settings.components.core.PreferenceIcon
import net.rpcsx.ui.settings.components.core.PreferenceValue
import net.rpcsx.ui.settings.components.preference.HomePreference
import net.rpcsx.ui.settings.components.preference.RegularPreference
import net.rpcsx.ui.settings.components.preference.SingleSelectionDialog
import net.rpcsx.ui.settings.components.preference.SliderPreference
import net.rpcsx.ui.settings.components.preference.SwitchPreference
import net.rpcsx.utils.FileUtil
import net.rpcsx.utils.GeneralSettings
import net.rpcsx.utils.InputBindingPrefs
Expand Down
5 changes: 0 additions & 5 deletions app/src/main/java/net/rpcsx/ui/settings/components/CompositionLocals.kt
View file
Open in desktop

This file was deleted.

154 changes: 0 additions & 154 deletions app/src/main/java/net/rpcsx/ui/settings/components/base/BaseDialogPreference.kt
View file
Open in desktop

This file was deleted.

131 changes: 0 additions & 131 deletions app/src/main/java/net/rpcsx/ui/settings/components/base/BasePreference.kt
View file
Open in desktop

This file was deleted.

Loading
Loading