Rename AbstractTokenOverlay#getAssets() to AbstractTokenOverlay#getAssetIds()

In `MultipleImageBarTokenOverlay`, replace the array-based accessor and mutator with `List`-based ones.

Author: kwvanderlinde

src/main/java/net/rptools/maptool/client/functions/BarImageFunction.java

@@ -78,11 +78,11 @@ public Object childEvaluate(
       }
     } else if (over instanceof MultipleImageBarTokenOverlay many) {
       int increment = 0;
-      int max_increments = many.getAssets().size();
+      int max_increments = many.getAssetIds().size();
       if (value != null) {
         increment = Math.clamp(over.findIncrement(value.doubleValue()), 0, max_increments);
       }
-      assetId.append(many.getAssets().get(increment).toString());
+      assetId.append(many.getAssetIds().get(increment).toString());
     } else {
       throw new ParserException(
           I18N.getText("macro.function.barImage.notImage", functionName, barName));

src/main/java/net/rptools/maptool/client/ui/campaignproperties/TokenBarController.java

@@ -603,7 +603,7 @@ public void valueChanged(ListSelectionEvent e) {
         } // endif
 
         // Handle images
-        var assetIds = bar.getAssets();
+        var assetIds = bar.getAssetIds();
         if (bar instanceof TwoImageBarTokenOverlay two) {
           type = 0;
         } else if (bar instanceof SingleImageBarTokenOverlay one) {

src/main/java/net/rptools/maptool/client/ui/token/AbstractImageTokenOverlay.java

@@ -43,7 +43,7 @@ public MD5Key getAssetId() {
   }
 
   @Override
-  public List<MD5Key> getAssets() {
+  public List<MD5Key> getAssetIds() {
     return List.of(assetId);
   }
 }

src/main/java/net/rptools/maptool/client/ui/token/AbstractTokenOverlay.java

@@ -262,7 +262,7 @@ public boolean showPlayer(Token token, Player player) {
   /**
    * @return The keys for all assets required by the overlay.
    */
-  public List<MD5Key> getAssets() {
+  public List<MD5Key> getAssetIds() {
     return List.of();
   }
 

src/main/java/net/rptools/maptool/client/ui/token/MultipleImageBarTokenOverlay.java

@@ -108,23 +108,16 @@ public void paintOverlay(Graphics2D g, Token token, Rectangle bounds, double val
     g.setComposite(tempComposite);
   }
 
-  /**
-   * @return Getter for bottomAssetId
-   */
-  public MD5Key[] getAssetIds() {
-    return assetIds;
+  @Override
+  public List<MD5Key> getAssetIds() {
+    return List.of(assetIds);
   }
 
   /**
    * @param theAssetIds Setter for bottomAssetId
    */
-  public void setAssetIds(MD5Key[] theAssetIds) {
-    this.assetIds = theAssetIds;
-  }
-
-  @Override
-  public List<MD5Key> getAssets() {
-    return List.of(assetIds);
+  public void setAssetIds(List<MD5Key> theAssetIds) {
+    this.assetIds = theAssetIds.toArray(MD5Key[]::new);
   }
 
   public static BarTokenOverlay fromDto(BarTokenOverlayDto dto) {

src/main/java/net/rptools/maptool/client/ui/token/SingleImageBarTokenOverlay.java

@@ -141,7 +141,7 @@ public MD5Key getAssetId() {
   }
 
   @Override
-  public List<MD5Key> getAssets() {
+  public List<MD5Key> getAssetIds() {
     return List.of(assetId);
   }
 

src/main/java/net/rptools/maptool/client/ui/token/TwoImageBarTokenOverlay.java

@@ -174,7 +174,7 @@ public void setTopAssetId(MD5Key topAssetId) {
   }
 
   @Override
-  public List<MD5Key> getAssets() {
+  public List<MD5Key> getAssetIds() {
     return List.of(this.topAssetId, this.bottomAssetId);
   }
 

src/main/java/net/rptools/maptool/model/CampaignProperties.java

@@ -665,12 +665,12 @@ public Set<MD5Key> getAllImageAssets() {
 
     // States have images as well
     for (BooleanTokenOverlay overlay : getTokenStatesMap().values()) {
-      set.addAll(overlay.getAssets());
+      set.addAll(overlay.getAssetIds());
     }
 
     // Bars
     for (BarTokenOverlay overlay : getTokenBarsMap().values()) {
-      set.addAll(overlay.getAssets());
+      set.addAll(overlay.getAssetIds());
     }
     return set;
   }