Preserve Jsvalue with a slab instead of unstable abi methods#78
Open
ealmloff wants to merge 5 commits into
Open
Preserve Jsvalue with a slab instead of unstable abi methods#78ealmloff wants to merge 5 commits into
ealmloff wants to merge 5 commits into
Conversation
ealmloff
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently serde-wasm-bindgen relies on the unstable wasm bindgen
convertmodule to store raw indexes into the js object map which can break in any minor release.This PR reworks the implementation to instead store a index into a slab of stashed jsvalues on the rust side instead of relying on that unstable abi. This makes serialization ~15% slower for preserved JsValues. My assumption is that this path is not performance critical since it serializes the same id string alongside every jsvalue.