Skip to content

fix(markdown): fix time was rendered as number and empty div#3870

Closed
cscnk52 wants to merge 4 commits into
RSSNext:devfrom
cscnk52:remove-remark-directive
Closed

fix(markdown): fix time was rendered as number and empty div#3870
cscnk52 wants to merge 4 commits into
RSSNext:devfrom
cscnk52:remove-remark-directive

Conversation

@cscnk52

@cscnk52 cscnk52 commented Jun 5, 2025

Copy link
Copy Markdown
Contributor

Description

PR Type

  • Feature
  • Bugfix
  • Hotfix
  • Other (please describe):

Screenshots (if UI change)

Before:

image

After:

image

Demo Video (if new feature)

Linked Issues

Additional context

This issue is caused by remark-directive not rendering timestamps like 01:26 correctly — for example, it renders 01:26 as 01 <div></div>.

Since I don't think the content rendered by this dependency is frequently used, I decided to remove it.

If remark-directive is indeed useful, feel free to close this PR — I’ll try to find another way to fix the issue.

Project homepage: https://github.com/remarkjs/remark-directive

Changelog

  • I have updated the changelog/next.md with my changes.

- this was introduced by remark-directive dependence
- and the kind of content rendered by remark-directive don't use frequency
@follow-reviewer-bot

Copy link
Copy Markdown

Thank you for your contribution. We will review it promptly.

@vercel

vercel Bot commented Jun 5, 2025

Copy link
Copy Markdown

@cscnk52 is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

@Innei Innei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this plugin to parse markdown container syntax.

@cscnk52
cscnk52 marked this pull request as draft June 6, 2025 07:37
@cscnk52

cscnk52 commented Jun 6, 2025

Copy link
Copy Markdown
Contributor Author

I made a patch to micromark-extension-directive to prevent strings like :number from being transformed into <div></div> elements.

Only one test fails in micromark-extension-directive repo, which is as expected:

image

@cscnk52
cscnk52 marked this pull request as ready for review June 6, 2025 09:58
@cscnk52

cscnk52 commented Jun 10, 2025

Copy link
Copy Markdown
Contributor Author

I have changed since last review, please re-review it.

@cscnk52 cscnk52 closed this Jun 12, 2025
@cscnk52
cscnk52 deleted the remove-remark-directive branch July 15, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants