fix(markdown): fix time was rendered as number and empty div#3870
Closed
cscnk52 wants to merge 4 commits into
Closed
fix(markdown): fix time was rendered as number and empty div#3870cscnk52 wants to merge 4 commits into
cscnk52 wants to merge 4 commits into
Conversation
- this was introduced by remark-directive dependence - and the kind of content rendered by remark-directive don't use frequency
|
Thank you for your contribution. We will review it promptly. |
|
@cscnk52 is attempting to deploy a commit to the RSS3 Team on Vercel. A member of the Team first needs to authorize it. |
Innei
suggested changes
Jun 6, 2025
Innei
left a comment
Contributor
There was a problem hiding this comment.
We need this plugin to parse markdown container syntax.
cscnk52
marked this pull request as draft
June 6, 2025 07:37
Contributor
Author
cscnk52
marked this pull request as ready for review
June 6, 2025 09:58
Contributor
Author
|
I have changed since last review, please re-review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
PR Type
Screenshots (if UI change)
Before:
After:
Demo Video (if new feature)
Linked Issues
Additional context
This issue is caused by
remark-directivenot rendering timestamps like01:26correctly — for example, it renders01:26as01 <div></div>.Since I don't think the content rendered by this dependency is frequently used, I decided to remove it.
If
remark-directiveis indeed useful, feel free to close this PR — I’ll try to find another way to fix the issue.Project homepage: https://github.com/remarkjs/remark-directive
Changelog