fix(icon): polished icon#3956
Conversation
|
@cscnk52 is attempting to deploy a commit to the RSS3 Team on Vercel. A member of the Team first needs to authorize it. |
|
Good job |
|
Simple-icons have been merged simple-icons/simple-icons#13443 , This PR still need to wait for Simple-icons and shields.io's next release, after that, we can simply add |
- change viewbox to 24 - merge path
|
Is this PR ready to be merged now? @cscnk52 |
|
I still have other things about icon to do, but now, should merge this PR first. In this PR, I change these things:
I change Folo SVG icon only contain path, so icon will be more clear, but, maybe some CSS class about Icon need to change, such as change under apps/desktop/layer/renderer/src/modules/entry-content/components/EntryPlaceholderLogo.tsx
The icon file under
Unify SVG icon viewbox to 24, single path, compress SVG, transform Circle and other SVG Object to path, remove padding in icon.
changed under apps/ssr/src/router/og/__base.tsx see diff: I also want to do these things, but not yet compleat:
I will do above things in another PR. Now This PR can be merged, please review it before merge. |
|
Thank you for your contribution! 🎉 Your pull request has been merged and we really appreciate your help in making this project better. We hope to see more contributions from you in the future! 💪 |
Description
related to simple-icons/simple-icons#13443
The PR use re-optimized icon in simple-icons,
waiting for simple-icons review.ReviewedAnd request @DIYgod review in this repo.
To-dos
(This need wait for SimpleIcons and shields.io next release)finished in docs: polish badge #4230og diff:
before | after