fix

Author: htynkn

bsp/gd32/arm/libraries/gd32_drivers/drv_rtc.c

@@ -25,19 +25,19 @@ typedef struct {
 static gd32_rtc_device g_gd32_rtc_dev;
 
 /**
- * @brief  辅助函数：BCD码 转换为 二进制.
- * @param  val: BCD码值.
- * @return 二进制值.
+ * @brief  Helper function: Convert BCD value to binary.
+ * @param  val: BCD value.
+ * @return Binary value.
  */
 static rt_uint8_t bcd_to_bin(rt_uint8_t val)
 {
     return (val & 0x0F) + ((val >> 4) & 0x0F) * 10;
 }
 
 /**
- * @brief  辅助函数：二进制 转换为 BCD码.
- * @param  val: 二进制值.
- * @return BCD码值.
+ * @brief  Helper function: Convert binary to BCD.
+ * @param  val: Binary value.
+ * @return BCD value.
  */
 static rt_uint8_t bin_to_bcd(rt_uint8_t val)
 {
@@ -52,8 +52,8 @@ static time_t get_rtc_timestamp(void)
 
     rtc_current_time_get(&rtc_current_time);
 
-    tm_new.tm_year = bcd_to_bin(rtc_current_time.rtc_year) + 100; // tm_year 是从1900年开始的年份
-    tm_new.tm_mon  = bcd_to_bin(rtc_current_time.rtc_month) - 1;  // tm_mon 是 0-11 的月份
+    tm_new.tm_year = bcd_to_bin(rtc_current_time.rtc_year) + 100; // tm_year: years since 1900
+    tm_new.tm_mon  = bcd_to_bin(rtc_current_time.rtc_month) - 1;  // tm_mon: month (0 = January, 11 = December)
     tm_new.tm_mday = bcd_to_bin(rtc_current_time.rtc_date);
     tm_new.tm_hour = bcd_to_bin(rtc_current_time.rtc_hour);
     tm_new.tm_min  = bcd_to_bin(rtc_current_time.rtc_minute);
@@ -75,40 +75,36 @@ static rt_err_t set_rtc_timestamp(time_t time_stamp)
     struct tm *p_tm;
     rtc_parameter_struct rtc_init_struct;
 
-    /* 将time_t时间戳转换为tm结构体 */
     p_tm = gmtime(&time_stamp);
-    /* GD32的RTC年份从2000年算起，所以tm_year必须大于等于100 (2000-1900) */
+
+    /* GD32 RTC uses year starting from 2000; thus tm_year must be at least 100 (i.e., 2000 - 1900) */
+    
     if (p_tm->tm_year < 100)
     {
         return -RT_ERROR;
     }
 
-    /* 使用tm结构体中的值，转换为BCD码并填充GD32的RTC初始化结构体 */
     rtc_init_struct.rtc_year = bin_to_bcd(p_tm->tm_year - 100);
     rtc_init_struct.rtc_month = bin_to_bcd(p_tm->tm_mon + 1);
     rtc_init_struct.rtc_date = bin_to_bcd(p_tm->tm_mday);
-    /* tm_wday的周日是0，而GD32的RTC周日是7 */
+
     rtc_init_struct.rtc_day_of_week = bin_to_bcd(p_tm->tm_wday == 0 ? 7 : p_tm->tm_wday);
     rtc_init_struct.rtc_hour = bin_to_bcd(p_tm->tm_hour);
     rtc_init_struct.rtc_minute = bin_to_bcd(p_tm->tm_min);
     rtc_init_struct.rtc_second = bin_to_bcd(p_tm->tm_sec);
     rtc_init_struct.rtc_display_format = RTC_24HOUR;
 
-    /* 对于GD32E23x，预分频器值必须在初始化时一并设置 */
 #if defined(BSP_RTC_USING_LSI)
-    /* 使用内部40KHz低速时钟IRC40K时的预分频参数 */
     rtc_init_struct.rtc_factor_asyn = 39;
     rtc_init_struct.rtc_factor_syn = 999;
 #elif defined(BSP_RTC_USING_LSE)
-    /* 使用外部32.768KHz低速晶振LXTAL时的预分频参数 */
     rtc_init_struct.rtc_factor_asyn = 127;
     rtc_init_struct.rtc_factor_syn = 255;
 #endif
 
-    /* 调用固件库函数来初始化RTC并设置时间 */
     if (rtc_init(&rtc_init_struct) != SUCCESS)
     {
-        LOG_E("RTC时间设置失败。");
+        LOG_E("Failed to set RTC time.");
         return -RT_ERROR;
     }
 

bsp/gd32/arm/libraries/gd32_drivers/drv_usart_v2.c

@@ -602,23 +602,19 @@ void DMA_Channel1_2_IRQHandler(void)
     /* enter interrupt */
     rt_interrupt_enter();
 
-    // 检查是否是 Channel 1 (TX) 的传输完成中断
     if (dma_interrupt_flag_get(DMA_CH1, DMA_INT_FLAG_FTF) != RESET)
     {
         dma_interrupt_flag_clear(DMA_CH1, DMA_INT_FLAG_G);
         dma_tx_isr(&uart_obj[UART0_INDEX].serial);
     }
 
-    // 检查是否是 Channel 2 (RX) 的半传输或全传输中断
     if (dma_interrupt_flag_get(DMA_CH2, DMA_INT_FLAG_HTF) != RESET)
     {
-        // 清除所有相关标志位
         dma_interrupt_flag_clear(DMA_CH2, DMA_INT_FLAG_HTF);
         dma_recv_isr(&uart_obj[UART0_INDEX].serial);
     }
     else if (dma_interrupt_flag_get(DMA_CH2, DMA_INT_FLAG_FTF) != RESET)
     {
-        // 清除所有相关标志位
         dma_interrupt_flag_clear(DMA_CH2, DMA_INT_FLAG_FTF);
         dma_recv_isr(&uart_obj[UART0_INDEX].serial);
     }
@@ -650,22 +646,20 @@ void DMA_Channel3_4_IRQHandler(void)
 {
     rt_interrupt_enter();
 
-    // 检查是否是 Channel 3 (TX) 的传输完成中断
     if (dma_interrupt_flag_get(DMA_CH3, DMA_INT_FLAG_FTF) != RESET)
     {
-        dma_interrupt_flag_clear(DMA_CH3, DMA_INT_FLAG_G); // 清除所有相关标志位
+        dma_interrupt_flag_clear(DMA_CH3, DMA_INT_FLAG_G);
         dma_tx_isr(&uart_obj[UART1_INDEX].serial);
     }
 
-    // 检查是否是 Channel 4 (RX) 的半传输或全传输中断
     if (dma_interrupt_flag_get(DMA_CH4, DMA_INT_FLAG_HTF) != RESET)
     {
-        dma_interrupt_flag_clear(DMA_CH4, DMA_INT_FLAG_HTF); // 清除所有相关标志位
+        dma_interrupt_flag_clear(DMA_CH4, DMA_INT_FLAG_HTF);
         dma_recv_isr(&uart_obj[UART1_INDEX].serial);
     }
     if (dma_interrupt_flag_get(DMA_CH4, DMA_INT_FLAG_FTF) != RESET)
     {
-        dma_interrupt_flag_clear(DMA_CH4, DMA_INT_FLAG_FTF); // 清除所有相关标志位
+        dma_interrupt_flag_clear(DMA_CH4, DMA_INT_FLAG_FTF);
         dma_recv_isr(&uart_obj[UART1_INDEX].serial);
     }
 
@@ -1017,7 +1011,6 @@ static void gd32_dma_config (struct rt_serial_device *serial, rt_ubase_t flag)
         dma_init_struct.direction = DMA_MEMORY_TO_PERIPHERAL;
         dma_init_struct.priority = DMA_PRIORITY_HIGH;
 
-        /* 4. 使用结构体初始化DMA通道 */
         dma_init(uart->dma.tx.channel, &dma_init_struct);
 
         /* enable tx dma interrupt */