Skip to content

[dfs] enable procfs and tempfs in default when using smart; fix LWIP_… #10292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rbb666 merged 3 commits into from
May 20, 2025
Merged

[dfs] enable procfs and tempfs in default when using smart; fix LWIP_… #10292

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9464fe1
[dfs] enable procfs and tempfs in default when using smart; fix LWIP_…
BernardXiong May 19, 2025
c45fa21
[DeviceDrivers] mount procfs when enable procfs
BernardXiong May 19, 2025
f24e433
[procfs] fix compiler warnings
BernardXiong May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion components/dfs/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ if RT_USING_SMART
default y
config RT_USING_DFS_PROCFS
bool "Enable proc file system"
default n
default y
Copy link

Copilot AI May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Update for RT_USING_DFS_PROCFS default is appropriate; however, add an inline comment explaining that enabling procfs by default under smart is intentional to improve maintainability.

Copilot uses AI. Check for mistakes.
endif

config RT_USING_DFS_CROMFS
Expand All @@ -204,11 +204,13 @@ endif

config RT_USING_DFS_TMPFS
bool "Enable TMP file system"
default y if RT_USING_SMART
Copy link

Copilot AI May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] For clarity, consider including a comment that details why TMPFS (and similarly MQUEUE on line 213) is conditionally enabled when using smart configurations.

Copilot uses AI. Check for mistakes.
default n

config RT_USING_DFS_MQUEUE
bool "Enable MQUEUE file system"
select RT_USING_DEV_BUS
default y if RT_USING_SMART
default n

if RT_USING_DFS_V1
Expand Down
2 changes: 2 additions & 0 deletions components/dfs/dfs_v2/filesystems/procfs/proc_net.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ static void *seq_next(struct dfs_seq_file *seq, void *data, off_t *index)
return NULL;
}

#if LWIP_ROUTE
Copy link

Copilot AI May 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider adding a comment explaining that the route_show function is conditionally compiled based on the LWIP_ROUTE flag to clarify its dependency for future maintainers.

Copilot uses AI. Check for mistakes.
static void route_show(const char *name, uint32_t ip_addr, uint32_t netmask, void *parameter)
{
struct dfs_seq_file *seq = (struct dfs_seq_file *)parameter;
Expand All @@ -66,6 +67,7 @@ static void route_show(const char *name, uint32_t ip_addr, uint32_t netmask, voi
dfs_seq_printf(seq, "%d ", 0);
dfs_seq_printf(seq, "%d\n", 0);
}
#endif

static int seq_show(struct dfs_seq_file *seq, void *data)
{
Expand Down
Loading