Skip to content

[Kernel][Object] Remove object name assertions, use rt_strncpy for safe truncation #10943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rbb666 merged 4 commits into from
Nov 19, 2025
Merged

[Kernel][Object] Remove object name assertions, use rt_strncpy for safe truncation #10943

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e5d46f5
Initial plan
Copilot Nov 17, 2025
6ce5619
Remove object name length assertions, keep error messages
Copilot Nov 17, 2025
65c2dee
Fix buffer overflow when object name exceeds RT_NAME_MAX
Copilot Nov 17, 2025
9a4f00c
Use rt_strncpy instead of manual truncation for object names
Copilot Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/object.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ void rt_object_init(struct rt_object *object,
if(obj_name_len > RT_NAME_MAX - 1)
{
LOG_E("Object name %s exceeds RT_NAME_MAX=%d, consider increasing RT_NAME_MAX.", name, RT_NAME_MAX);
RT_ASSERT(obj_name_len <= RT_NAME_MAX - 1);
obj_name_len = RT_NAME_MAX - 1;

@kurisaW kurisaW Nov 18, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这一句直接去掉就好了

@Rbb666 Rbb666 Nov 18, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要@copilot才能修改哦

Copilot AI Nov 18, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已更新，使用 rt_strncpy 替代手动截断。Commit: 9a4f00c

Updated to use rt_strncpy instead of manual truncation. Commit: 9a4f00c

}
rt_memcpy(object->name, name, obj_name_len);
object->name[obj_name_len] = '\0';
Expand Down Expand Up @@ -515,7 +515,7 @@ rt_object_t rt_object_allocate(enum rt_object_class_type type, const char *name)
if(obj_name_len > RT_NAME_MAX - 1)
{
LOG_E("Object name %s exceeds RT_NAME_MAX=%d, consider increasing RT_NAME_MAX.", name, RT_NAME_MAX);
RT_ASSERT(obj_name_len <= RT_NAME_MAX - 1);
obj_name_len = RT_NAME_MAX - 1;
}
rt_memcpy(object->name, name, obj_name_len);
object->name[obj_name_len] = '\0';
Expand Down
Loading