Skip to content

[BSP][NS800RT7P65] Add WDG driver for NS800RT7xxx#11451

Merged
Rbb666 merged 3 commits into
RT-Thread:masterfrom
rcitach:rcitach/iwdg
Jun 11, 2026
Merged

[BSP][NS800RT7P65] Add WDG driver for NS800RT7xxx#11451
Rbb666 merged 3 commits into
RT-Thread:masterfrom
rcitach:rcitach/iwdg

Conversation

@rcitach

@rcitach rcitach commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:rcitach/iwdg
  • 设置PR number为 \ Set the PR number to:11451
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 rcitach/iwdg 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the rcitach/iwdg branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added BSP BSP: Novosns BSP related with novosns labels Jun 8, 2026
@Rbb666 Rbb666 requested a review from Copilot June 11, 2026 02:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds watchdog (WDT) support to the Novosense NS800RT7P65 BSP by introducing independent watchdog (IWDG1/IWDG2) and window watchdog (WWDG) drivers, plus the Kconfig/CI/build-script wiring needed to enable them.
本 PR 为 Novosense NS800RT7P65 BSP 增加看门狗(WDT)支持,引入独立看门狗(IWDG1/IWDG2)与窗口看门狗(WWDG)驱动,并补齐对应的 Kconfig / CI / 构建脚本配置。

Changes / 变更点:

  • Add BSP Kconfig options for enabling WDT and selecting IWDG1/IWDG2/WWDG instances.
    新增 BSP Kconfig 选项,用于启用 WDT 并选择 IWDG1/IWDG2/WWDG 实例。
  • Add new HAL driver implementations for IWDG (IWDG1/IWDG2) and WWDG, registered via rt_hw_watchdog_register.
    新增 IWDG(IWDG1/IWDG2)与 WWDG HAL 驱动实现,并通过 rt_hw_watchdog_register 注册设备。
  • Update CI attachconfig and driver SConscript to compile these drivers under corresponding Kconfig switches.
    更新 CI attachconfig 与驱动 SConscript,使其在对应 Kconfig 打开时参与编译。

Notes / 备注(需在合入前处理):

  • PR 标题前缀目前为大写 [BSP][NS800RT7P65],不符合仓库要求的小写前缀格式(建议类似 [bsp][ns800rt7p65] ...)。
  • PR 描述仍保留模板占位内容(方括号内未填写),按模板要求这会阻挡合并。

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
bsp/novosns/ns800/ns800rt7p65-nssinepad/board/Kconfig Adds Kconfig switches for WDT and individual watchdog instances.
bsp/novosns/ns800/ns800rt7p65-nssinepad/.ci/attachconfig/ci.attachconfig.yml Adds CI build configs for ADC/SPI/WDT (but currently also enables QSPI).
bsp/novosns/ns800/libraries/HAL_Drivers/drivers/SConscript Adds conditional build of WDT drivers (and currently references missing drv_qspi.c).
bsp/novosns/ns800/libraries/HAL_Drivers/drivers/drv_iwdg.h Public init API and device names for IWDG1/IWDG2.
bsp/novosns/ns800/libraries/HAL_Drivers/drivers/drv_iwdg.c Implements IWDG1/IWDG2 watchdog operations and registration.
bsp/novosns/ns800/libraries/HAL_Drivers/drivers/drv_wwdg.h Public init API and device name for WWDG.
bsp/novosns/ns800/libraries/HAL_Drivers/drivers/drv_wwdg.c Implements WWDG watchdog operations and registration (timeout math and API semantics need adjustments).

Comment thread bsp/novosns/ns800/libraries/HAL_Drivers/drivers/drv_wwdg.c Outdated
Comment thread bsp/novosns/ns800/libraries/HAL_Drivers/drivers/drv_wwdg.c
Comment thread bsp/novosns/ns800/libraries/HAL_Drivers/drivers/drv_wwdg.c
Comment thread bsp/novosns/ns800/libraries/HAL_Drivers/drivers/drv_wwdg.c Outdated
Comment thread bsp/novosns/ns800/libraries/HAL_Drivers/drivers/SConscript Outdated
@Rbb666 Rbb666 merged commit bb5c904 into RT-Thread:master Jun 11, 2026
12 checks passed
@rcitach rcitach deleted the rcitach/iwdg branch June 11, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: Novosns BSP related with novosns BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants