Skip to content

Commit 5ff7666

Browse files
committed
address review comments
1 parent b49de1c commit 5ff7666

2 files changed

Lines changed: 13 additions & 7 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@ Bug fix checklist:
3232
New feature checklist:
3333
- [ ] I have added or updated the docstrings associated with my feature using the [numpy docstring format](https://numpydoc.readthedocs.io/en/latest/format.html).
3434
- [ ] I have updated the tutorial to highlight my new feature (if appropriate).
35-
- [ ] I have added tests to cover my new feature.
35+
- [ ] I have added/updated tests to cover my new feature.
3636
- [ ] I have updated the [CHANGELOG](https://github.com/RadioAstronomySoftwareGroup/pyuvdata/blob/main/CHANGELOG.md).
3737

3838
Breaking change checklist:
3939
- [ ] I have updated the docstrings associated with my change using the [numpy docstring format](https://numpydoc.readthedocs.io/en/latest/format.html).
4040
- [ ] I have updated the tutorial to reflect my changes (if appropriate).
4141
- [ ] My change includes backwards compatibility and deprecation warnings (if possible).
42-
- [ ] I have added tests to cover my changes.
42+
- [ ] I have added/updated tests to cover my changes.
4343
- [ ] I have updated the [CHANGELOG](https://github.com/RadioAstronomySoftwareGroup/pyuvdata/blob/main/CHANGELOG.md).
4444

4545
Documentation change checklist:
@@ -56,5 +56,5 @@ Build or continuous integration change checklist:
5656
Other:
5757
- [ ] I have updated any docstrings associated with my change using the [numpy docstring format](https://numpydoc.readthedocs.io/en/latest/format.html).
5858
- [ ] I have updated the readme and/or tutorial to reflect my changes (if appropriate).
59-
- [ ] I have added tests to cover my changes (if appropriate).
59+
- [ ] I have added/updated tests to cover my changes (if appropriate).
6060
- [ ] I have updated the [CHANGELOG](https://github.com/RadioAstronomySoftwareGroup/pyuvdata/blob/main/CHANGELOG.md).

README.md

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,16 @@ and uvh5 files and reading of FHD
1212
([Fast Holographic Deconvolution](https://github.com/EoRImaging/FHD)) visibility
1313
save files, SMA Mir files and MWA correlator FITS files.
1414

15-
API documentation and a tutorial is hosted on [ReadTheDocs](https://pyuvdata.readthedocs.io).
15+
Documentation of the API, conventions used throughout the package, and a tutorial
16+
is hosted on [ReadTheDocs](https://pyuvdata.readthedocs.io).
1617

1718
# Motivation
1819
The main goals are:
1920

2021
1. To provide a high quality, well documented path to convert between file formats.
2122
2. Support the direct use of interferometric datasets from python with minimal software.
22-
3. Provide precise data definition via both human readable code and high quality documentation.
23+
3. Provide precise data definitions and convention details via both human
24+
readable code and high quality documentation.
2325

2426
# Package Details
2527
pyuvdata has four major user classes:
@@ -39,8 +41,9 @@ Also can convert raw data quality metrics into flags using thresholding.
3941
tested with ATCA files. Reading/writing Miriad files is not supported on Windows.
4042
* UVFITS conforms to AIPS memo 117 (as of March 2020). It is tested against
4143
FHD, CASA, and AIPS. However AIPS is limited to <80 antennas and CASA's ``importuvfits``
42-
task does not seem to support >255 antennas. In general, users planning to work
43-
in CASA should use the measurement set writer instead.
44+
task does not seem to support >255 antennas. Because of this and other limitations
45+
to CASA's ``importuvfits`` task, we reccommend that users planning to work in CASA
46+
avoid using ``importuvfits`` and use the measurement set writer instead.
4447
* CASA measurement sets, primarily conforming to
4548
[CASA Memo 229](https://casa.nrao.edu/Memos/229.html), with some elements taken
4649
from the proposed v3.0 format documented in
@@ -81,6 +84,9 @@ metadata, details here: [cst settings file](docs/cst_settings_yaml.rst)
8184
* MWA Beams (read only support)
8285

8386
## Known Issues and Planned Improvements
87+
* Incorporating numba to alleviate bottlenecks and to replace some existing
88+
cython extensions as appropriate.
89+
8490
See our [issue log](https://github.com/RadioAstronomySoftwareGroup/pyuvdata/issues)
8591
for a full list.
8692

0 commit comments

Comments
 (0)