remove spice dependency from tests for updated lunarsky#620
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #620 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 2455 2455
=========================================
Hits 2455 2455 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@burdorfmitchell I think we'll need you to update the lunar reference sim data before we can merge this PR. The new lunarsky version is available on pypi. |
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: d1f4d93 | Previous: a1f5f5f | Ratio |
|---|---|---|---|
tests/test_run_ref.py::test_run_sim[1.1_baseline_number] |
0.3075095117381496 iter/sec (stddev: 0.09821328241750245) |
0.4723100939736393 iter/sec (stddev: 0.08542779550019207) |
1.54 |
This comment was automatically generated by workflow using github-action-benchmark.
|
The lunar reference simulation has been updated on the Brown Digital Repository. |
Thank you!! |
|
hmm, @aelanman it looks like it's passing the test for array equality but it's somewhat slower than the older version. We can merge it as is and make an issue for speeding up lunarsky if you like. |
Description
The latest version of lunarsky drops the dependency on spiceypy. As a result, the try blocks that catch SPICEUnknownFrameErrors in unit tests can be removed. This also bumps the minimum version of lunarsky.
Motivation and Context
This cleans up code that will no longer be needed.
Build or continuous integration change checklist: