Allow to have parameters for an action#718
Merged
Conversation
use action_t struct instead of a simple enum: Initial work
* MapActionW has to handle a terminating '=' as well as a NULL. * strtoi() must stop on any non digit (fix). * fix static_assert() macro for pre C11.
Step_1_XX, Step_2_50...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use action_t struct instead of a simple enum.
OK: Read parameters and store them in action_t struct.
a) OK: for normal Alt+Click actions
b) OK: done for Hotkeys, also a list of actions_t structs must be made to keep track of parameters, the list index is used for registering shortcut.
TODO: Make UI for intuitive parameters selection with smart default values.
Action have parameters separated with underscores.
Step_U_50 = Step Up 50 pixels