Fix default browser detection using malformed URL NSWorkspace.urlForA…#5224
Open
umutkonmus wants to merge 1 commit intoRanchero-Software:mainfrom
Open
Fix default browser detection using malformed URL NSWorkspace.urlForA…#5224umutkonmus wants to merge 1 commit intoRanchero-Software:mainfrom
umutkonmus wants to merge 1 commit intoRanchero-Software:mainfrom
Conversation
…pplication(toOpen:) was called with "https:///" (malformed, no host), which caused macOS to sometimes return Safari regardless of the actual system default browser. Fixed by using a valid HTTPS URL (https://apple.com/) so the system correctly resolves the default handler. Also fixed the browser popup selection logic to explicitly handle the nil-defaultBrowserID case, and removed force-unwraps on icon/name. Fixes Ranchero-Software#5220
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix default browser detection using malformed URL NSWorkspace.urlForApplication(toOpen:) was called with "https:///"
(malformed, no host), which caused macOS to sometimes return Safari regardless of the actual system default browser.
Fixed by using a valid HTTPS URL (https://apple.com/) so the system correctly resolves the default handler.
Also fixed the browser popup selection logic to explicitly handle the nil-defaultBrowserID case, and removed force-unwraps on icon/name.
Fixes #5220