Skip to content

Fix Full Article extraction for Naver Blog #5228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
box-j wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −3
Open

Fix Full Article extraction for Naver Blog #5228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions Shared/Article Extractor/ArticleExtractor.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,10 @@ public enum ArticleExtractorState: Sendable {

let clientURL = "https://extract.feedbin.com/parser"
let username = SecretKey.mercuryClientID
let signature = articleLink.hmacUsingSHA1(key: SecretKey.mercuryClientSecret)
let extractionLink = ArticleExtractor.extractionURL(for: articleLink)
let signature = extractionLink.hmacUsingSHA1(key: SecretKey.mercuryClientSecret)

if let base64URL = articleLink.data(using: .utf8)?.base64EncodedString() {
if let base64URL = extractionLink.data(using: .utf8)?.base64EncodedString() {
let fullURL = "\(clientURL)/\(username)/\(signature)?base64_url=\(base64URL)"
if let url = URL(string: fullURL) {
self.url = url
Expand All @@ -51,7 +52,28 @@ public enum ArticleExtractorState: Sendable {
return nil
}

public func process() {
/// Returns a URL string optimized for extraction, applying site-specific transformations where needed.
static func extractionURL(for articleLink: String) -> String {
guard let url = URL(string: articleLink),
let host = url.host()?.lowercased() else {
return articleLink
}

// Naver Blog desktop URLs use a JavaScript-heavy SPA that extractors can't parse.
// The mobile site (m.blog.naver.com) renders as static HTML and works correctly.
if host == "blog.naver.com" {
var components = URLComponents(url: url, resolvingAgainstBaseURL: false)
components?.host = "m.blog.naver.com"
components?.query = nil
if let mobileURL = components?.url {
return mobileURL.absoluteString
}
}

return articleLink
}

public func process() {

state = .processing

Expand Down