Commit fb61a88
Path A.2: f64 support in scalar + dual-band lowerers
Floats live on the operand stack as bitcast IEEE-754 bit patterns
inside i64-shaped slots. The bytecode-typed AddFloat / SubFloat /
MulFloat ops bitcast back to f64 at their boundary, do the float
math, and bitcast the result back to i64 for storage. The to_int
and to_float intrinsics handle the int↔float conversion at the
language boundary (sitofp / fptosi via bitcast).
Why bitcast-via-i64 instead of typing the whole stack: the lowerer
already uses Vec<IntValue> as the operand stack. Adding a tagged
StackItem enum would have touched every op handler. The bitcast
trick keeps the existing path unchanged and only the float-typed
ops (Add/Sub/MulFloat) and the conversion intrinsics need to know
about the encoding. Bytecode compiler enforces type discipline
upstream — the JIT trusts the typed op.
Implementation surface:
- Const::Float in LoadConst → const_int(f.to_bits())
- Op::AddFloat/SubFloat/MulFloat in scalar lowerer via new bin_float
helper (bitcast-i64-to-f64, op, bitcast back)
- Op::AddFloat/SubFloat/MulFloat in dual-band lowerer via
bin_vec_float helper (<2 x i64> bitcasts to <2 x f64>; both
lanes get the parallel float op; bitcast back to <2 x i64>)
- Op::Call("to_float", 1): pop i64, sitofp f64, bitcast to i64
- Op::Call("to_int", 1): pop i64, bitcast f64, fptosi i64
- Mirrored intrinsics in dual-band: operate on α lane only,
splat result back as matched-band <r, r>
Tests (3 new, all passing):
- float_round_trip_to_int_and_back: to_int(to_float(x)) == x for
any int x (proves the bitcast encoding)
- float_arithmetic_via_to_float: area(r) = to_int(rf * rf) where
rf = to_float(r) — exercises MulFloat
- float_loop_accumulator: sum_squares(n) using float Add/Mul in
a while loop. Verified against closed form n(n+1)(2n+1)/6
for n=1,2,3,10,100 (1, 5, 14, 385, 338,350)
Out of scope for Path A.2 (deferred):
- Float-typed Div / Mod: the OMC bytecode compiler doesn't yet
emit DivFloat (Op::Div is always emitted, regardless of type),
so the JIT would do integer division on float bit-patterns and
produce garbage. Would need a compiler-side change to emit
DivFloat when both operands are statically float, and then a
matching JIT op. Documented in the test comment.
- Float comparison ops (FloatPredicate::OEQ etc.) — comparisons
happen on the int representation today, which gives wrong
answers for negative zeros and NaNs. Same story as Div.
- Float fn parameters or returns: signature stays scalar i64;
callers convert at the boundary via to_float / to_int.
- Tracking var-slot type so a variable can hold either int or
float across stores: currently a single alloca i64 holds
either kind via bitcast. That's correct as long as the
compiler doesn't mix types into the same slot, which the
type-tracking it does today should prevent.
Workspace: 34 codegen tests pass (1 IR snapshot + 4 cross-fn +
5 dual-band + 5 dispatch + 3 harmony + 3 floats + 5 phi_shadow +
8 scalar). Smoke + harmonic-lib + 149 core tests still green.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>1 parent 37fa0c5 commit fb61a88
3 files changed
Lines changed: 329 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
272 | 276 | | |
273 | 277 | | |
274 | | - | |
| 278 | + | |
275 | 279 | | |
276 | 280 | | |
277 | 281 | | |
278 | 282 | | |
279 | | - | |
| 283 | + | |
280 | 284 | | |
281 | 285 | | |
282 | 286 | | |
| |||
319 | 323 | | |
320 | 324 | | |
321 | 325 | | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
322 | 335 | | |
323 | 336 | | |
324 | 337 | | |
| |||
486 | 499 | | |
487 | 500 | | |
488 | 501 | | |
| 502 | + | |
| 503 | + | |
| 504 | + | |
| 505 | + | |
| 506 | + | |
| 507 | + | |
| 508 | + | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
| 522 | + | |
| 523 | + | |
| 524 | + | |
| 525 | + | |
| 526 | + | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
489 | 555 | | |
490 | 556 | | |
491 | 557 | | |
| |||
780 | 846 | | |
781 | 847 | | |
782 | 848 | | |
| 849 | + | |
| 850 | + | |
| 851 | + | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
| 855 | + | |
| 856 | + | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
| 882 | + | |
| 883 | + | |
| 884 | + | |
| 885 | + | |
| 886 | + | |
| 887 | + | |
| 888 | + | |
| 889 | + | |
| 890 | + | |
| 891 | + | |
783 | 892 | | |
784 | 893 | | |
785 | 894 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
564 | 564 | | |
565 | 565 | | |
566 | 566 | | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
567 | 575 | | |
568 | 576 | | |
569 | | - | |
| 577 | + | |
570 | 578 | | |
571 | 579 | | |
572 | 580 | | |
| |||
612 | 620 | | |
613 | 621 | | |
614 | 622 | | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
| 634 | + | |
615 | 635 | | |
616 | 636 | | |
617 | 637 | | |
| |||
767 | 787 | | |
768 | 788 | | |
769 | 789 | | |
| 790 | + | |
| 791 | + | |
| 792 | + | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
770 | 821 | | |
771 | 822 | | |
772 | 823 | | |
| |||
873 | 924 | | |
874 | 925 | | |
875 | 926 | | |
| 927 | + | |
| 928 | + | |
| 929 | + | |
| 930 | + | |
| 931 | + | |
| 932 | + | |
| 933 | + | |
| 934 | + | |
| 935 | + | |
| 936 | + | |
| 937 | + | |
| 938 | + | |
| 939 | + | |
| 940 | + | |
| 941 | + | |
| 942 | + | |
| 943 | + | |
| 944 | + | |
| 945 | + | |
| 946 | + | |
| 947 | + | |
| 948 | + | |
| 949 | + | |
| 950 | + | |
| 951 | + | |
| 952 | + | |
| 953 | + | |
| 954 | + | |
| 955 | + | |
| 956 | + | |
| 957 | + | |
| 958 | + | |
| 959 | + | |
| 960 | + | |
| 961 | + | |
| 962 | + | |
| 963 | + | |
| 964 | + | |
| 965 | + | |
| 966 | + | |
| 967 | + | |
| 968 | + | |
| 969 | + | |
| 970 | + | |
| 971 | + | |
| 972 | + | |
| 973 | + | |
876 | 974 | | |
877 | 975 | | |
878 | 976 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
0 commit comments