Encodes that fail to produce an output file but report success are now reported correctly as failed.

Author: RandomEngy

VidCoder/Services/Logger.cs

@@ -47,7 +47,9 @@ public string LogText
 
 		public void Log(string message)
 		{
-			this.RecordMessage(message);
+			string prefix = string.IsNullOrEmpty(message) ? string.Empty : "# ";
+
+			this.RecordMessage(prefix + message);
 		}
 
 		public void ClearLog()

VidCoder/Services/ProcessAutoPause.cs

@@ -110,7 +110,7 @@ private void PollTimerElapsed(object sender, ElapsedEventArgs e)
 						if (autoPauseProcess == null)
 						{
 							this.autoPaused = false;
-							this.logger.Log("# Automatically resuming, processes are gone.");
+							this.logger.Log("Automatically resuming, processes are gone.");
 
 							if (this.ResumeEncoding != null)
 							{
@@ -123,7 +123,7 @@ private void PollTimerElapsed(object sender, ElapsedEventArgs e)
 						if (autoPauseProcess != null)
 						{
 							this.autoPaused = true;
-							this.logger.Log("# Automatically pausing, process detected: " + autoPauseProcess);
+							this.logger.Log("Automatically pausing, process detected: " + autoPauseProcess);
 							if (this.PauseEncoding != null)
 							{
 								this.PauseEncoding(this, new EventArgs());

VidCoder/ViewModel/MainViewModel.cs

@@ -2315,7 +2315,7 @@ public EncodeJob EncodeJob
 		public void StartEncodeQueue()
 		{
 			this.EncodeProgressState = TaskbarItemProgressState.Normal;
-			this.logger.Log("## Starting queue");
+			this.logger.Log("Starting queue");
 
 			this.totalTasks = this.EncodeQueue.Count;
 			this.taskNumber = 0;
@@ -2373,10 +2373,10 @@ private void StartEncode()
 		{
 			EncodeJob job = this.CurrentJob.Job;
 
-			this.logger.Log("## Starting job " + this.taskNumber + "/" + this.totalTasks);
-			this.logger.Log("##   Path: " + job.SourcePath);
-			this.logger.Log("##   Title: " + job.Title);
-			this.logger.Log("##   Chapters: " + job.ChapterStart + "-" + job.ChapterEnd);
+			this.logger.Log("Starting job " + this.taskNumber + "/" + this.totalTasks);
+			this.logger.Log("  Path: " + job.SourcePath);
+			this.logger.Log("  Title: " + job.Title);
+			this.logger.Log("  Chapters: " + job.ChapterStart + "-" + job.ChapterEnd);
 			this.CurrentJob.HandBrakeInstance.EncodeProgress += this.OnEncodeProgress;
 			this.CurrentJob.HandBrakeInstance.EncodeCompleted += this.OnEncodeCompleted;
 
@@ -2507,18 +2507,36 @@ private void OnEncodeCompleted(object sender, EncodeCompletedEventArgs e)
 						this.EncodeQueue.Clear();
 					}
 
-					this.logger.Log("## Encoding stopped");
+					this.logger.Log("Encoding stopped");
 				}
 				else
 				{
 					// If the encode completed successfully
 					this.completedQueueWork += this.EncodeQueue[0].Cost;
 
+					var outputFileInfo = new FileInfo(this.CurrentJob.Job.OutputPath);
+					bool succeeded = true;
+					if (e.Error)
+					{
+						succeeded = false;
+						this.logger.Log("Encode failed. HandBrake reported an error.");
+					}
+					else if (!outputFileInfo.Exists)
+					{
+						succeeded = false;
+						this.logger.Log("Encode failed. HandBrake reported no error but the expected output file was not found.");
+					}
+					else if (outputFileInfo.Length == 0)
+					{
+						succeeded = false;
+						this.logger.Log("Encode failed. HandBrake reported no error but the output file was empty.");
+					}
+
 					this.CompletedJobs.Add(new EncodeResultViewModel(
 						new EncodeResult
 						{
 							Destination = this.CurrentJob.Job.OutputPath,
-							Succeeded = !e.Error,
+							Succeeded = succeeded,
 							EncodeTime = this.CurrentJob.EncodeTime
 						}));
 					this.NotifyPropertyChanged("CompletedItemsCount");
@@ -2530,14 +2548,14 @@ private void OnEncodeCompleted(object sender, EncodeCompletedEventArgs e)
 
 					this.CleanupHandBrakeInstance(finishedInstance);
 
-					this.logger.Log("## Job completed");
+					this.logger.Log("Job completed");
 
 					if (this.EncodeQueue.Count == 0)
 					{
 						this.SelectedTabIndex = CompletedTabIndex;
 						this.StopEncodingAndReport();
 
-						this.logger.Log("## Queue completed");
+						this.logger.Log("Queue completed");
 						this.logger.Log("");
 					}
 					else
@@ -3005,7 +3023,7 @@ private void StartScan(string path)
 				this.CleanupHandBrakeInstance(oldInstance);
 			}
 
-			this.logger.Log("## Starting scan: " + path);
+			this.logger.Log("Starting scan: " + path);
 
 			this.scanInstance = new HandBrakeInstance();
 			this.scanInstance.Initialize(Settings.Default.LogVerbosity);
@@ -3026,12 +3044,12 @@ private void StartScan(string path)
 							this.ScanCancelled(this, new EventArgs());
 						}
 
-						this.logger.Log("## Scan cancelled");
+						this.logger.Log("Scan cancelled");
 					}
 					else
 					{
 						this.SourceData = new VideoSource { Titles = this.scanInstance.Titles, FeatureTitle = this.scanInstance.FeatureTitle };
-						this.logger.Log("## Scan completed");
+						this.logger.Log("Scan completed");
 					}
 
 					this.logger.Log("");

VidCoder/ViewModel/PreviewViewModel.cs

@@ -229,8 +229,8 @@ public ICommand GeneratePreviewCommand
 					this.generatePreviewCommand = new RelayCommand(param =>
 					{
 						this.job = this.mainViewModel.EncodeJob;
-						this.logger.Log("## Generating preview clip");
-						this.logger.Log("## Scanning title");
+						this.logger.Log("Generating preview clip");
+						this.logger.Log("Scanning title");
 
 						this.previewInstance = new HandBrakeInstance();
 						this.previewInstance.Initialize(Settings.Default.LogVerbosity);
@@ -644,7 +644,7 @@ private void OnPreviewScanCompleted(object sender, EventArgs eventArgs)
 			if (this.encodeCancelled)
 			{
 				this.GeneratingPreview = false;
-				this.logger.Log("# Cancelled preview clip generation");
+				this.logger.Log("Cancelled preview clip generation");
 				return;
 			}
 
@@ -685,27 +685,27 @@ private void OnPreviewScanCompleted(object sender, EventArgs eventArgs)
 
 				if (this.encodeCancelled)
 				{
-					this.logger.Log("# Cancelled preview clip generation");
+					this.logger.Log("Cancelled preview clip generation");
 				}
 				else
 				{
 					if (e.Error)
 					{
-						this.logger.Log("# Preview clip generation failed");
+						this.logger.Log("Preview clip generation failed");
 						Utilities.MessageBox.Show("Preview clip generation failed. See the Log window for details.");
 					}
 					else
 					{
-						this.logger.Log("# Finished preview clip generation");
+						this.logger.Log("Finished preview clip generation");
 						FileService.Instance.LaunchFile(previewFilePath);
 					}
 				}
 			};
 
-			this.logger.Log("## Encoding clip");
-			this.logger.Log("##   Path: " + this.job.OutputPath);
-			this.logger.Log("##   Title: " + this.job.Title);
-			this.logger.Log("##   Preview #: " + this.SelectedPreview);
+			this.logger.Log("Encoding clip");
+			this.logger.Log("  Path: " + this.job.OutputPath);
+			this.logger.Log("  Title: " + this.job.Title);
+			this.logger.Log("  Preview #: " + this.SelectedPreview);
 
 			this.previewInstance.StartEncode(this.job, true, this.SelectedPreview, this.PreviewSeconds);
 		}