Fixed an issue where scan failures on jobs added by the Watcher would stay marked as "Planned".

Author: RandomEngy

VidCoder/Services/HandBrakeProxy/RemoteScanProxy.cs

@@ -22,14 +22,14 @@ public async void StartScan(string path, IAppLogger logger)
 		await this.RunOperationAsync(worker => worker.StartScan(path));
 	}
 
-        public void OnScanProgress(float fractionComplete)
-        {
-            this.ScanProgress?.Invoke(this, new EventArgs<float>(fractionComplete));
-        }
+    public void OnScanProgress(float fractionComplete)
+    {
+		this.ScanProgress?.Invoke(this, new EventArgs<float>(fractionComplete));
+    }
 
-        public void OnScanComplete(string scanJson)
-        {
-            this.result = scanJson;
+	public void OnScanComplete(string scanJson)
+	{
+		this.result = scanJson;
 
 		Task.Run(async () =>
 		{
@@ -43,7 +43,7 @@ public void OnScanComplete(string scanJson)
 				this.ProcessLock.Release();
 			}
 		});
-        }
+	}
 
 	protected override HandBrakeWorkerAction Action => HandBrakeWorkerAction.Scan;
 
@@ -52,5 +52,5 @@ public void OnScanComplete(string scanJson)
 	protected override void OnOperationEnd(VCEncodeResultCode result)
 	{
             this.ScanCompleted?.Invoke(this, new EventArgs<string>(this.result));
-        }
+	}
 }

VidCoder/Services/QueueAdderService.cs

@@ -39,6 +39,11 @@ public class QueueAdderService : ReactiveObject
 	private bool isCanceled = false;
 	private bool startPending = false;
 
+	/// <summary>
+	/// Fires when a scan failed because there are no titles.
+	/// </summary>
+	public event EventHandler<EventArgs<string>> ScanFailed;
+
 	public double Progress
 	{
 		get
@@ -136,9 +141,15 @@ private void EnsureScanProxyCreated()
 						return;
 					}
 
+					bool scanFoundTitle = true;
 					if (args.Value != null)
 					{
 						JsonScanObject scanObject = JsonSerializer.Deserialize<JsonScanObject>(args.Value, JsonOptions.Plain);
+						if (scanObject.TitleList.Count == 0)
+						{
+							scanFoundTitle = false;
+						}
+
 						this.scanResults.Add(
 							new ScanResult
 							{
@@ -161,6 +172,13 @@ private void EnsureScanProxyCreated()
 					{
 						// Add to list of failed files, pop a dialog at the end
 						this.failedFiles.Add(this.currentScan.SourcePath.Path);
+
+						scanFoundTitle = false;
+					}
+
+					if (!scanFoundTitle)
+					{
+						this.ScanFailed.Invoke(this, new EventArgs<string>(this.currentScan.SourcePath.Path));
 					}
 
 					this.scansCompletedThisSession++;

VidCoder/Services/WatchedFileStatusTracker.cs

@@ -17,19 +17,22 @@ namespace VidCoder.Services;
 public class WatchedFileStatusTracker
 {
 	private ProcessingService processingService;
+	private QueueAdderService queueAdderService;
 
 	private IAppLogger logger = StaticResolver.Resolve<IAppLogger>();
 
-	public WatchedFileStatusTracker(ProcessingService processingService)
+	public WatchedFileStatusTracker(ProcessingService processingService, QueueAdderService queueAdderService)
 	{
 		this.processingService = processingService;
+		this.queueAdderService = queueAdderService;
 	}
 
 	public void Start()
 	{
 		this.processingService.JobCompleted += this.OnJobCompleted;
 		this.processingService.JobRemovedFromQueue += this.OnJobRemovedFromQueue;
 		this.processingService.JobQueueSkipped += this.OnJobQueueSkipped;
+		this.queueAdderService.ScanFailed += this.OnScanFailed;
 
 		SQLiteConnection connection = Database.Connection;
 
@@ -86,4 +89,12 @@ private void OnJobQueueSkipped(object sender, EventArgs<string> e)
 			e.Value,
 			WatchedFileStatus.Skipped);
 	}
+
+	private void OnScanFailed(object sender, EventArgs<string> e)
+	{
+		WatcherStorage.UpdateEntryStatus(
+			Database.Connection,
+			e.Value,
+			WatchedFileStatus.Failed);
+	}
 }

VidCoder/ViewModel/WatcherWindowViewModel.cs

@@ -41,6 +41,7 @@ public class WatcherWindowViewModel : ReactiveObject, IClosableWindow
 
 	private PresetsService presetsService = StaticResolver.Resolve<PresetsService>();
 	private ProcessingService processingService = StaticResolver.Resolve<ProcessingService>();
+	private QueueAdderService queueAdderService = StaticResolver.Resolve<QueueAdderService>();
 
 	private readonly Dictionary<WatchedFileStatusLive, bool> statusFilters = new();
 
@@ -338,6 +339,7 @@ public void CancelSelectedFiles()
 
 	private void SubscribeToJobEvents()
 	{
+		this.queueAdderService.ScanFailed += this.OnScanFailed;
 		this.processingService.JobQueued += this.OnJobQueued;
 		this.processingService.JobQueueSkipped += this.OnJobQueueSkipped;
 		this.processingService.JobRemovedFromQueue += this.OnJobRemovedFromQueue;
@@ -349,6 +351,7 @@ private void SubscribeToJobEvents()
 
 	private void UnsubscribeFromJobEvents()
 	{
+		this.queueAdderService.ScanFailed -= this.OnScanFailed;
 		this.processingService.JobQueued -= this.OnJobQueued;
 		this.processingService.JobQueueSkipped -= this.OnJobQueueSkipped;
 		this.processingService.JobRemovedFromQueue -= this.OnJobRemovedFromQueue;
@@ -358,6 +361,15 @@ private void UnsubscribeFromJobEvents()
 		this.processingService.WatchedFilesRemoved -= this.OnWatchedFilesRemoved;
 	}
 
+	private void OnScanFailed(object sender, EventArgs<string> e)
+	{
+		WatchedFileViewModel watchedFile = this.GetWatchedFileForSourcePath(e.Value);
+		if (watchedFile != null)
+		{
+			watchedFile.Status = WatchedFileStatusLive.Failed;
+		}
+	}
+
 	private void OnJobQueued(object sender, EventArgs<EncodeJobViewModel> e)
 	{
 		WatchedFileViewModel watchedFile = this.GetWatchedFileForJob(e.Value);