Added current user to VidCoderAutomation pipe name, which should prevent CLI actions from acting on another logged in user's VidCoder instance.

Author: RandomEngy

VidCoder/Automation/AutomationHost.cs

@@ -1,14 +1,15 @@
-using System;
+using PipeMethodCalls;
+using PipeMethodCalls.NetJson;
+using System;
 using System.Collections.Generic;
 using System.Diagnostics;
 using System.Linq;
 using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
-using PipeMethodCalls;
-using PipeMethodCalls.NetJson;
 using VidCoderCommon;
 using VidCoderCommon.Services;
+using VidCoderCommon.Utilities;
 
 namespace VidCoder.Automation;
 
@@ -25,9 +26,10 @@ public static async void StartListening()
 		{
 			while (true)
 			{
+				string pipeName = "VidCoderAutomation" + (CommonUtilities.Beta ? "Beta" : string.Empty) + PipeUtilities.UserPipeSuffix;
 				using (server = new PipeServer<IVidCoderAutomation>(
 					new NetJsonPipeSerializer(),
-					"VidCoderAutomation" + (CommonUtilities.Beta ? "Beta" : string.Empty),
+					pipeName,
 					() => new VidCoderAutomation()))
 				{
 					await server.WaitForConnectionAsync().ConfigureAwait(false);

VidCoderCommon/Services/AutomationClient.cs

@@ -7,6 +7,7 @@
 using System.Text;
 using System.Threading.Tasks;
 using VidCoderCommon.Model;
+using VidCoderCommon.Utilities;
 
 namespace VidCoderCommon.Services;
 
@@ -38,7 +39,8 @@ public async Task<AutomationResult> TryActionAsync(Expression<Action<IVidCoderAu
 				betaString = "Beta";
 			}
 
-			using (var client = new PipeClient<IVidCoderAutomation>(new NetJsonPipeSerializer(), "VidCoderAutomation" + betaString))
+			string pipeName = "VidCoderAutomation" + betaString + PipeUtilities.UserPipeSuffix;
+			using (var client = new PipeClient<IVidCoderAutomation>(new NetJsonPipeSerializer(), pipeName))
 			{
 				await client.ConnectAsync().ConfigureAwait(false);
 				await client.InvokeAsync(action).ConfigureAwait(false);

VidCoderCommon/Utilities/PipeUtilities.cs

@@ -0,0 +1,25 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+
+namespace VidCoderCommon.Utilities;
+
+public static class PipeUtilities
+{
+	/// <summary>
+	/// To prevent cross-contamination of pipes between users, we append the username to the pipe name.
+	/// We sanitize the username to ensure it only contains valid characters for a pipe name.
+	/// </summary>
+	public static string UserPipeSuffix => SanitizePipeSegment(Environment.UserName);
+
+	private static string SanitizePipeSegment(string s)
+	{
+		if (string.IsNullOrEmpty(s))
+		{
+			return string.Empty;
+		}
+
+		return new string(s.Select(c => (char.IsLetterOrDigit(c) || c == '_' || c == '-' || c == '.') ? c : '_').ToArray());
+	}
+}