Fix 'fetch' not being able to find an item at all, and 'update' not being able to ever update#1
Open
holl0wstar wants to merge 3 commits into
Open
Fix 'fetch' not being able to find an item at all, and 'update' not being able to ever update#1holl0wstar wants to merge 3 commits into
holl0wstar wants to merge 3 commits into
Conversation
So, this fixes a fairly peculiar issue with the `fetch` method. The `const data = await this.fetchAll(config);` method returns an `Array`, and the old code used `hasOwnProperty`, which is meant for objects. That meant the code would always return false, and whatever the engine was looking for would never be found. After a bit of brainstorming with Sean, we figured it out. I changed it to a `find` method, instead, and it works like a charm.
Author
|
I made a change to the It feels a bit hacky, but it works. |
holl0wstar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, this fixes a fairly peculiar issue with the
fetchmethod.The
const data = await this.fetchAll(config);method returns anArray, and the old code usedhasOwnProperty, which is meant for objects. That meant the code would always return false, and whatever the engine was looking for would never be found.After a bit of brainstorming with Sean, we figured it out. I changed it to a
findmethod, instead, and it works like a charm.My bundle, Wvnder -- A OLC system I'm working on, depends on these changes. There may be more to come, since I've only patched up the YAML sources for the Rooms for the time being.