Fix Guild.edit safety_alerts_channel None handling#10449
Closed
kadam257 wants to merge 1 commit into
Closed
Conversation
Author
|
Just noticed #10446 already fixes both pieces of this. Closing as duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
safety_alerts_channelonGuild.editwas typed asTextChanneldespite the docstring sayingOptional[TextChannel],and passing
Nonecrashed because the.idassignment ran outsidethe
else:branch. Widens the type and fixes the indent to matchthe sibling
rules_channel/public_updates_channelblocks.Closes #10445
Checklist