Skip to content

Commit 882072d

Browse files
authored
Merge pull request #2684 from viliml/patch-checkbox
Fix handling of checkbox values in developer tools
2 parents d37ef17 + b6d8e71 commit 882072d

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

examples/developer-tools/src/output-generators/fields/checkbox.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ jsonDefinitionGenerator.forBlock['field_checkbox'] = function (
3030
const code = {
3131
type: 'field_checkbox',
3232
name: block.getFieldValue('FIELDNAME'),
33-
checked: block.getFieldValue('CHECKED'),
33+
checked: block.getFieldValue('CHECKED') === 'TRUE',
3434
};
3535
return JSON.stringify(code);
3636
};
@@ -40,7 +40,7 @@ javascriptDefinitionGenerator.forBlock['field_checkbox'] = function (
4040
generator: JavascriptDefinitionGenerator,
4141
): string {
4242
const name = generator.quote_(block.getFieldValue('FIELDNAME'));
43-
const checked = generator.quote_(block.getFieldValue('CHECKED'));
43+
const checked = block.getFieldValue('CHECKED') === 'TRUE';
4444
return `.appendField(new Blockly.FieldCheckbox(${checked}), ${name})`;
4545
};
4646

examples/developer-tools/src/output-generators/fields/image.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jsonDefinitionGenerator.forBlock['field_image'] = function (
3333
width: block.getFieldValue('WIDTH'),
3434
height: block.getFieldValue('HEIGHT'),
3535
alt: block.getFieldValue('ALT'),
36-
flipRtl: block.getFieldValue('FLIP_RTL'),
36+
flipRtl: block.getFieldValue('FLIP_RTL') === 'TRUE',
3737
};
3838
return JSON.stringify(code);
3939
};
@@ -46,7 +46,7 @@ javascriptDefinitionGenerator.forBlock['field_image'] = function (
4646
const width = block.getFieldValue('WIDTH');
4747
const height = block.getFieldValue('HEIGHT');
4848
const alt = generator.quote_(block.getFieldValue('ALT'));
49-
const flipRtl = generator.quote_(block.getFieldValue('FLIP_RTL'));
49+
const flipRtl = block.getFieldValue('FLIP_RTL') === 'TRUE';
5050

5151
const code = `.appendField(new Blockly.FieldImage(${src}, ${width}, ${height}, { alt: ${alt}, flipRtl: ${flipRtl}}))`;
5252
return code;

0 commit comments

Comments
 (0)