Skip to content

Commit da5e8e6

Browse files
authored
fix: enforce placeholder usage for workspace comment (#9463)
* fix: enforce placeholder usage for workspace comment Signed-off-by: SimonShiki <sinangentoo@gmail.com> * fix: lint Signed-off-by: SimonShiki <sinangentoo@gmail.com> --------- Signed-off-by: SimonShiki <sinangentoo@gmail.com>
1 parent 8a226d8 commit da5e8e6

2 files changed

Lines changed: 5 additions & 1 deletion

File tree

core/comments/comment_editor.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import * as browserEvents from '../browser_events.js';
88
import {getFocusManager} from '../focus_manager.js';
99
import {IFocusableNode} from '../interfaces/i_focusable_node.js';
1010
import {IFocusableTree} from '../interfaces/i_focusable_tree.js';
11+
import {Msg} from '../msg.js';
1112
import * as touch from '../touch.js';
1213
import * as dom from '../utils/dom.js';
1314
import {Rect} from '../utils/rect.js';
@@ -56,6 +57,10 @@ export class CommentEditor implements IFocusableNode {
5657
) as HTMLTextAreaElement;
5758
this.textArea.setAttribute('tabindex', '-1');
5859
this.textArea.setAttribute('dir', this.workspace.RTL ? 'RTL' : 'LTR');
60+
this.textArea.setAttribute(
61+
'placeholder',
62+
Msg['WORKSPACE_COMMENT_DEFAULT_TEXT'],
63+
);
5964
dom.addClass(this.textArea, 'blocklyCommentText');
6065
dom.addClass(this.textArea, 'blocklyTextarea');
6166
dom.addClass(this.textArea, 'blocklyText');

core/contextmenu_items.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,6 @@ export function registerCommentCreate() {
636636
if (!workspace) return;
637637
eventUtils.setGroup(true);
638638
const comment = new RenderedWorkspaceComment(workspace);
639-
comment.setPlaceholderText(Msg['WORKSPACE_COMMENT_DEFAULT_TEXT']);
640639
comment.moveTo(
641640
svgMath.screenToWsCoordinates(
642641
workspace,

0 commit comments

Comments
 (0)