small refactor for non student abilities

Author: rammodhvadia

app/models/ability.rb

@@ -4,7 +4,7 @@ class Ability
   include CanCan::Ability
 
   def initialize(user)
-    define_common_non_student_abilities(user)
+    define_common_abilities
 
     return unless user
 
@@ -21,10 +21,7 @@ def initialize(user)
 
   private
 
-  def define_common_non_student_abilities(user)
-    can :show, Project, user_id: nil, school_id: nil, project_type: Project::Types::CODE_EDITOR_SCRATCH
-    return if user&.student?
-
+  def define_common_abilities
     # Anyone can view projects not owned by a user or a school.
     can :show, Project, user_id: nil, school_id: nil
     can :show, Component, project: { user_id: nil, school_id: nil }

spec/models/ability_spec.rb

@@ -492,7 +492,7 @@
 
       context 'with a starter project' do
         it { is_expected.not_to be_able_to(:index, starter_project) }
-        it { is_expected.not_to be_able_to(:show, starter_project) }
+        it { is_expected.to be_able_to(:show, starter_project) }
         it { is_expected.not_to be_able_to(:create, starter_project) }
         it { is_expected.not_to be_able_to(:update, starter_project) }
         it { is_expected.not_to be_able_to(:destroy, starter_project) }