Simplify safeguarding role lookup after changes

Author: abcampo-iry

app/services/safeguarding_flag_service.rb

@@ -5,11 +5,7 @@ class << self
     def create_for_school_roles(user:, school:)
       return if user.blank? || school.blank?
 
-      roles = []
-      roles << :teacher if user.school_teacher?(school)
-      roles << :owner if user.school_owner?(school)
-
-      create_for_roles(token: user.token, email: user.email, school:, roles:)
+      create_for_roles(token: user.token, email: user.email, school:, roles: user.school_roles(school))
     end
 
     def create_for_token(token:, school:)

lib/concepts/school_member/list.rb

@@ -42,9 +42,9 @@ def call(school:, token:)
       private
 
       def fetch_students(school:, token:)
-        student_roles = Role.student.where(school:)
+        return OperationResponse[school_students: []] unless Role.student.exists?(school:)
 
-        student_roles.any? ? SchoolStudent::List.call(school:, token:) : OperationResponse[school_students: []]
+        SchoolStudent::List.call(school:, token:)
       end
 
       def build_student_members(students)