feat: update the logging

Author: DNR500

app/controllers/api/subscriptions_controller.rb

@@ -6,26 +6,27 @@ def create
       payload = subscription_params.to_h
       errors = validation_errors_for(payload)
 
-      Rails.logger.warn(
-        "[subscriptions#create] payload=#{payload.inspect} result=#{errors.empty? ? 'success' : 'failure'}"
-      )
-
       if errors.empty?
         submit_result = subscriptions_submitter.call(form_payload: payload)
         if submit_result.success?
+          Rails.logger.info('[subscriptions#create] outcome=success')
           render json: {
             ok: true,
             message: 'Subscription accepted',
             subscription: payload
           }, status: :ok
         else
+          Rails.logger.warn(
+            "[subscriptions#create] outcome=failure error_code=#{submit_result.error_code}"
+          )
           render json: {
             ok: false,
             error_code: submit_result.error_code,
             message: submit_result.message
           }, status: submit_result.status
         end
       else
+        Rails.logger.warn('[subscriptions#create] outcome=failure error_code=subscription_validation_failed')
         render json: {
           ok: false,
           error_code: 'subscription_validation_failed',

app/services/subscriptions/pardot_form_handler_submitter.rb

@@ -24,8 +24,8 @@ def call(form_payload:)
         "classification=#{classification_for(response)}"
       )
       classify_response(response)
-    rescue Faraday::Error
-      # Sentry.capture_exception(e)
+    rescue Faraday::Error => e
+      Sentry.capture_exception(e)
       Result.new(
         success?: false,
         status: :service_unavailable,