Follow rubocop recommendations for using params

I've reviewed all these changes and they look like the params are always required

https://redirect.github.com/rubocop/rubocop-rails/pull/1583

Author: zetter-rpf

app/controllers/admin/projects_controller.rb

@@ -9,7 +9,7 @@ def scoped_resource
     end
 
     def destroy_image
-      image = requested_resource.images.find(params[:image_id])
+      image = requested_resource.images.find(params.expect(:image_id))
       image.purge
       redirect_back_or_to(requested_resource)
     end

app/controllers/api/feedback_controller.rb

@@ -31,7 +31,7 @@ def create
     end
 
     def set_read
-      feedback = Feedback.find(params[:id])
+      feedback = Feedback.find(params.expect(:id))
       result = Feedback::SetRead.call(feedback: feedback)
 
       if result.success?

app/controllers/api/join_controller.rb

@@ -30,7 +30,7 @@ def create
     private
 
     def find_school_and_class
-      @school_class = SchoolClass.find_by!(join_code: JoinCodeGenerator.normalize(params[:join_code]))
+      @school_class = SchoolClass.find_by!(join_code: JoinCodeGenerator.normalize(params.expect(:join_code)))
       @school = @school_class.school
     end
 

app/controllers/api/projects/images_controller.rb

@@ -6,13 +6,13 @@ class ImagesController < ApiController
       before_action :authorize_user, only: %i[create]
 
       def show
-        @project = Project.find_by!(identifier: params[:project_id])
+        @project = Project.find_by!(identifier: params.expect(:project_id))
         authorize! :show, @project
         render '/api/projects/images', formats: [:json]
       end
 
       def create
-        @project = Project.find_by!(identifier: params[:project_id])
+        @project = Project.find_by!(identifier: params.expect(:project_id))
         authorize! :update, @project
         @project.images.attach(params[:images])
         render '/api/projects/images', formats: [:json]

app/controllers/api/projects/remixes_controller.rb

@@ -43,7 +43,7 @@ def create
       private
 
       def project
-        @project ||= Project.find_by!(identifier: params[:project_id])
+        @project ||= Project.find_by!(identifier: params.expect(:project_id))
       end
 
       def load_and_authorize_remix

app/controllers/api/school_classes_controller.rb

@@ -60,7 +60,7 @@ def import
     end
 
     def update
-      school_class = @school.classes.find(params[:id])
+      school_class = @school.classes.find(params.expect(:id))
       result = SchoolClass::Update.call(school_class:, school_class_params:)
 
       if result.success?
@@ -176,25 +176,25 @@ def assign_students_to_class(school_class, school_students)
     end
 
     def load_and_authorize_school
-      @school = if params[:school_id].match?(/\d\d-\d\d-\d\d/)
+      @school = if params.expect(:school_id).match?(/\d\d-\d\d-\d\d/)
                   School.find_by(code: params[:school_id])
                 else
-                  School.find(params[:school_id])
+                  School.find(params.expect(:school_id))
                 end
       authorize! :read, @school
     end
 
     def load_and_authorize_school_class
       if %w[index create import].include?(params[:action])
-        authorize! params[:action].to_sym, SchoolClass
+        authorize! params.expect(:action).to_sym, SchoolClass
       else
-        @school_class = if params[:id].match?(/\d\d-\d\d-\d\d/)
+        @school_class = if params.expect(:id).match?(/\d\d-\d\d-\d\d/)
                           @school.classes.find_by(code: params[:id])
                         else
-                          @school.classes.find(params[:id])
+                          @school.classes.find(params.expect(:id))
                         end
 
-        authorize! params[:action].to_sym, @school_class
+        authorize! params.expect(:action).to_sym, @school_class
       end
     end
 

app/controllers/api/school_projects_controller.rb

@@ -74,7 +74,7 @@ def set_finished
     private
 
     def project
-      @project ||= Project.find_by!(identifier: params[:id])
+      @project ||= Project.find_by!(identifier: params.expect(:id))
     end
 
     def school_project

app/controllers/api/schools_controller.rb

@@ -30,7 +30,7 @@ def create
     end
 
     def update
-      school = School.find(params[:id])
+      school = School.find(params.expect(:id))
       result = School::Update.call(school:, school_params: update_params)
 
       if result.success?

app/controllers/api/scratch/projects_controller.rb

@@ -101,7 +101,7 @@ def move_pending_scratch_upload_to_remix(pending_upload, remix_project)
       end
 
       def load_project
-        @project = Project.find_by!(identifier: params[:id], project_type: Project::Types::CODE_EDITOR_SCRATCH)
+        @project = Project.find_by!(identifier: params.expect(:id), project_type: Project::Types::CODE_EDITOR_SCRATCH)
       end
     end
   end

app/models/project.rb

@@ -114,7 +114,7 @@ def create_school_project_if_needed
   end
 
   def identifier_cannot_be_taken_by_another_user
-    return if Project.where(identifier: self.identifier).where.not(user_id:).empty?
+    return if Project.where(identifier:).where.not(user_id:).empty?
 
     errors.add(:identifier, "can't be taken by another user")
   end