Skip to content

Commit 92c2038

Browse files
committed
Tidy up comments
1 parent 1e03fda commit 92c2038

2 files changed

Lines changed: 0 additions & 3 deletions

File tree

app/controllers/api/school_students_controller.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,6 @@ def destroy_batch
145145
private
146146

147147
def remove_students(student_ids)
148-
# Invoke StudentRemovalService
149148
service = StudentRemovalService.new(
150149
students: student_ids,
151150
school: @school,

app/services/student_removal_service.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ def remove_students
1313
results = []
1414

1515
@students.each do |user_id|
16-
# Ensure that the student has a role in this school and skip if not.
1716
student_roles = Role.student.where(user_id:, school_id: @school.id)
1817
if student_roles.empty?
1918
results << { user_id:, skipped: true, reason: 'no_role_in_school' }
@@ -35,7 +34,6 @@ def remove_students
3534
student_roles.destroy_all
3635

3736
# Remove from profile if requested - inside transaction so it can be rolled back
38-
# If this call fails, the entire transaction will be rolled back
3937
ProfileApiClient.delete_school_student(token: @token, school_id: @school.id, student_id: user_id) if @remove_from_profile && @token.present?
4038
end
4139
rescue StandardError => e

0 commit comments

Comments
 (0)