Skip to content

Commit beb9d05

Browse files
committed
switch statuses to symbols
1 parent cfa5f9e commit beb9d05

2 files changed

Lines changed: 10 additions & 10 deletions

File tree

app/controllers/api/school_projects_controller.rb

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ def show_status
1212

1313
def unsubmit
1414
authorize! :unsubmit, school_project
15-
result = SchoolProject::SetStatus.call(school_project:, status: 'unsubmitted', user_id: current_user.id)
15+
result = SchoolProject::SetStatus.call(school_project:, status: :unsubmitted, user_id: current_user.id)
1616
if result.success?
1717
@school_project = result[:school_project]
1818
render :show_status, formats: [:json], status: :ok
@@ -23,7 +23,7 @@ def unsubmit
2323

2424
def submit
2525
authorize! :submit, school_project
26-
result = SchoolProject::SetStatus.call(school_project:, status: 'submitted', user_id: current_user.id)
26+
result = SchoolProject::SetStatus.call(school_project:, status: :submitted, user_id: current_user.id)
2727
if result.success?
2828
@school_project = result[:school_project]
2929
render :show_status, formats: [:json], status: :ok
@@ -34,7 +34,7 @@ def submit
3434

3535
def return
3636
authorize! :return, school_project
37-
result = SchoolProject::SetStatus.call(school_project:, status: 'returned', user_id: current_user.id)
37+
result = SchoolProject::SetStatus.call(school_project:, status: :returned, user_id: current_user.id)
3838
if result.success?
3939
@school_project = result[:school_project]
4040
render :show_status, formats: [:json], status: :ok
@@ -45,7 +45,7 @@ def return
4545

4646
def complete
4747
authorize! :complete, school_project
48-
result = SchoolProject::SetStatus.call(school_project:, status: 'complete', user_id: current_user.id)
48+
result = SchoolProject::SetStatus.call(school_project:, status: :complete, user_id: current_user.id)
4949
if result.success?
5050
@school_project = result[:school_project]
5151
render :show_status, formats: [:json], status: :ok

spec/concepts/school_project/set_status_spec.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,17 +11,17 @@
1111
describe '.call' do
1212
context 'when status transition is successful' do
1313
it 'returns a successful operation response' do
14-
response = described_class.call(school_project:, status: 'submitted', user_id: student.id)
14+
response = described_class.call(school_project:, status: :submitted, user_id: student.id)
1515
expect(response.success?).to be(true)
1616
end
1717

1818
it 'updates the school project status' do
19-
described_class.call(school_project:, status: 'submitted', user_id: student.id)
19+
described_class.call(school_project:, status: :submitted, user_id: student.id)
2020
expect(school_project.status).to eq('submitted')
2121
end
2222

2323
it 'returns the updated school project in the response' do
24-
response = described_class.call(school_project:, status: 'submitted', user_id: student.id)
24+
response = described_class.call(school_project:, status: :submitted, user_id: student.id)
2525
expect(response[:school_project]).to be_a(SchoolProject)
2626
end
2727
end
@@ -32,17 +32,17 @@
3232
end
3333

3434
it 'returns a failed operation response' do
35-
response = described_class.call(school_project:, status: 'submitted', user_id: student.id)
35+
response = described_class.call(school_project:, status: :submitted, user_id: student.id)
3636
expect(response.success?).to be(false)
3737
end
3838

3939
it 'does not update the school project status' do
40-
described_class.call(school_project:, status: 'submitted', user_id: student.id)
40+
described_class.call(school_project:, status: :submitted, user_id: student.id)
4141
expect(school_project.status).to eq('unsubmitted')
4242
end
4343

4444
it 'includes the error message in the response' do
45-
response = described_class.call(school_project:, status: 'submitted', user_id: student.id)
45+
response = described_class.call(school_project:, status: :submitted, user_id: student.id)
4646
expect(response[:error]).to eq('Transition failed')
4747
end
4848
end

0 commit comments

Comments
 (0)