Propagate student listing errors in member lists

Author: abcampo-iry

lib/concepts/class_member/operations/list.rb

@@ -10,7 +10,10 @@ def call(school_class:, class_students:, token:)
         begin
           school = school_class.school
           student_ids = class_students.pluck(:student_id)
-          students = SchoolStudent::List.call(school:, token:, student_ids:).fetch(:school_students, [])
+          students_response = SchoolStudent::List.call(school:, token:, student_ids:)
+          return failure_response(response, students_response[:error]) if students_response.failure?
+
+          students = students_response.fetch(:school_students, [])
           class_students.each do |member|
             member.student = students.find { |student| student.id == member.student_id }
           end
@@ -29,6 +32,13 @@ def call(school_class:, class_students:, token:)
 
         response
       end
+
+      private
+
+      def failure_response(response, error)
+        response[:error] = error
+        response
+      end
     end
   end
 end

lib/concepts/school_member/list.rb

@@ -15,7 +15,10 @@ def call(school:, token:)
         response[:school_members] = []
 
         begin
-          students = fetch_students(school:, token:)
+          students_response = fetch_students(school:, token:)
+          return failure_response(response, students_response[:error]) if students_response.failure?
+
+          students = build_student_members(students_response.fetch(:school_students, []))
           teachers = fetch_teachers(school:)
           owners = fetch_owners(school:)
 
@@ -38,9 +41,11 @@ def call(school:, token:)
       def fetch_students(school:, token:)
         student_roles = Role.student.where(school:)
 
-        students_response = student_roles.any? ? SchoolStudent::List.call(school:, token:).fetch(:school_students, []) : []
+        student_roles.any? ? SchoolStudent::List.call(school:, token:) : OperationResponse[school_students: []]
+      end
 
-        students_response.map do |student|
+      def build_student_members(students)
+        students.map do |student|
           SchoolMember.new(student.id, student.name, student.username, student.email, :student, student.sso_providers)
         end
       end
@@ -60,6 +65,11 @@ def fetch_owners(school:)
           SchoolMember.new(owner.id, owner.name, nil, owner.email, :owner, [])
         end
       end
+
+      def failure_response(response, error)
+        response[:error] = error
+        response
+      end
     end
   end
 end

spec/concepts/class_member/list_spec.rb

@@ -72,8 +72,23 @@
       expect(Sentry).to have_received(:capture_exception).with(instance_of(StandardError))
     end
 
+    it 'propagates student listing operation errors' do
+      students.each do |student|
+        create(:class_student, school_class:, student_id: student.id)
+      end
+      allow(SchoolStudent::List).to receive(:call).and_return(
+        OperationResponse[error: 'Error listing school students: Some API error']
+      )
+
+      response = described_class.call(school_class:, class_students:, token:)
+
+      expect(response.failure?).to be(true)
+      expect(response[:error]).to eq('Error listing school students: Some API error')
+      expect(response[:class_members]).to eq([])
+    end
+
     it 'returns an empty array when no ids match' do
-      allow(SchoolStudent::List).to receive(:call).and_return({ school_students: [] })
+      allow(SchoolStudent::List).to receive(:call).and_return(OperationResponse[school_students: []])
       allow(SchoolTeacher::List).to receive(:call).and_return({ school_teachers: [] })
 
       response = described_class.call(school_class:, class_students:, token:)

spec/concepts/school_member/list_spec.rb

@@ -114,8 +114,20 @@
       expect(Sentry).to have_received(:capture_exception).with(instance_of(StandardError))
     end
 
+    it 'propagates student listing operation errors' do
+      allow(SchoolStudent::List).to receive(:call).and_return(
+        OperationResponse[error: 'Error listing school students: Some API error']
+      )
+
+      response = described_class.call(school:, token:)
+
+      expect(response.failure?).to be(true)
+      expect(response[:error]).to eq('Error listing school students: Some API error')
+      expect(response[:school_members]).to eq([])
+    end
+
     it 'returns an empty array when no ids match' do
-      allow(SchoolStudent::List).to receive(:call).and_return({ school_students: [] })
+      allow(SchoolStudent::List).to receive(:call).and_return(OperationResponse[school_students: []])
       allow(SchoolTeacher::List).to receive(:call).and_return({ school_teachers: [] })
 
       response = described_class.call(school:, token:)