Skip to content

Commit 3f5baa7

Browse files
authored
Fix contrast on dark mode instructions code block (#1187)
closes RaspberryPiFoundation/digital-editor-issues#416
1 parent c085612 commit 3f5baa7

2 files changed

Lines changed: 14 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
2121
- Instructions tabs for edit and viewing (#1167)
2222
- Add remove instructions button modal (#1176)
2323
- Dark mode colours (#1182)
24+
- Dark mode for instuctions code block (#1187)
2425

2526
### Changed
2627

src/assets/stylesheets/Instructions.scss

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242

4343
pre {
4444
background-color: $rpf-grey-700;
45+
border: 1px solid $rpf-grey-600;
4546
border-radius: 8px;
4647
padding: $space-0-5 $space-1;
4748
overflow: auto;
@@ -56,11 +57,12 @@
5657
}
5758

5859
.c-project-code {
59-
margin: $space-1 0 $space-1-5 0;
60-
border-radius: 8px;
6160
background-color: $rpf-grey-700;
61+
border-radius: 8px;
62+
margin: $space-1 0 $space-1-5 0;
6263

6364
pre {
65+
border: none;
6466
margin: 0;
6567
}
6668

@@ -280,6 +282,15 @@
280282
}
281283
}
282284

285+
.--dark .project-instructions {
286+
pre {
287+
background-color: $rpf-grey-850;
288+
}
289+
code {
290+
background-color: $rpf-grey-850;
291+
}
292+
}
293+
283294
#app,
284295
#wc {
285296
.c-instruction-tabs {

0 commit comments

Comments
 (0)