Commit b9481df
authored
Closes:
RaspberryPiFoundation/digital-editor-issues#690
## Summary
**Issue related:**
- Change tab `block-size` to `min-block-size` to allow height to grow
- Also change to correct custom property to ensure minimum target size
**Fixing failing tests:**
- The Skulpt runner implementation was hiding tab/elements by setting
block-size (height) to 0. As a result when using `min-block-size` this
was causing cypress visiblity test to fail.
- It was previously passing since cypress considers height 0 as not
visible.
- This implementation has now been changed to set `display: none` to
properly remove the element
- There are 2 other potential changes that could be made here
1. Conditially render the elements instead - as the
[PyodideRunner](https://github.com/RaspberryPiFoundation/editor-ui/blob/main/src/components/Editor/Runners/PythonRunner/PyodideRunner/PyodideRunner.jsx#L440)
does
2. Change the cypress test to check for
[existence](https://docs.cypress.io/api/commands/its#Existence) instead
- I've opted not to change the above to keep this PR smaller
## Demo

1 parent e869bc1 commit b9481df
3 files changed
Lines changed: 13 additions & 5 deletions
File tree
- src
- assets/stylesheets
- components/Editor/Runners/PythonRunner/SkulptRunner
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
9 | 16 | | |
10 | 17 | | |
11 | 18 | | |
| |||
19 | 26 | | |
20 | 27 | | |
21 | 28 | | |
22 | | - | |
23 | | - | |
24 | 29 | | |
25 | 30 | | |
26 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| |||
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
485 | 485 | | |
486 | 486 | | |
487 | 487 | | |
488 | | - | |
| 488 | + | |
489 | 489 | | |
490 | 490 | | |
491 | 491 | | |
| |||
549 | 549 | | |
550 | 550 | | |
551 | 551 | | |
552 | | - | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
553 | 556 | | |
554 | 557 | | |
555 | 558 | | |
| |||
0 commit comments