Skip to content

Commit d2f7028

Browse files
authored
Improve output panels with error messages (#1505)
Closes RaspberryPiFoundation/digital-editor-issues#1512 ### Changes - In smaller project container (`.project-wrapper` container in Project.scss): - Visual output panel and text output panel are split in 1:1. - min height of text panel set to 3rem. <img width="450" alt="Screenshot 2026-06-22 at 15 57 17" src="https://github.com/user-attachments/assets/930538b6-7e3c-43f8-9074-2bd78ac712e8" /> - In larger container (min-width: 720px): - Visual output panel and text output panel are split in 3:2. - min height of text panel increased to 4rem. <img width="600" alt="Screenshot 2026-06-22 at 15 58 07" src="https://github.com/user-attachments/assets/dc207c3f-4381-4aef-8de9-9bb4227c81a2" />
1 parent 62f5647 commit d2f7028

2 files changed

Lines changed: 18 additions & 3 deletions

File tree

src/assets/stylesheets/ErrorMessage.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
.error-message {
55
color: var(--rpf-red-900);
66
background-color: var(--rpf-red-100);
7-
border-block-start: 1px solid var(--editor-color-outline);
7+
border-block: 1px solid var(--editor-color-outline);
88
padding: var(--space-1);
99
overflow-y: auto;
1010
scrollbar-width: thin;

src/assets/stylesheets/PythonRunner.scss

Lines changed: 17 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,26 @@
9797
overflow: hidden;
9898

9999
&--text {
100-
flex: 3;
100+
flex: 1;
101+
102+
.react-tabs__tab-panel--selected {
103+
min-block-size: var(--space-6);
104+
}
105+
106+
@container (min-width: 720px) {
107+
flex: 2;
108+
.react-tabs__tab-panel--selected {
109+
min-block-size: var(--space-8);
110+
}
111+
}
101112
}
102113

103114
&--visual {
104-
flex: 7;
115+
flex: 1;
116+
117+
@container (min-width: 720px) {
118+
flex: 3;
119+
}
105120

106121
.--light & {
107122
border-block-end: 5px solid $rpf-grey-100;

0 commit comments

Comments
 (0)