Skip to content

Fix status bar overflow on mobile - #1217

Merged
jamiebenstead merged 8 commits into
mainfrom
fix-status-bar-overflow-on-mobile
Jun 18, 2025
Merged

Fix status bar overflow on mobile#1217
jamiebenstead merged 8 commits into
mainfrom
fix-status-bar-overflow-on-mobile

Conversation

@jamiebenstead

@jamiebenstead jamiebenstead commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

@jamiebenstead
jamiebenstead temporarily deployed to previews/1217/merge June 16, 2025 14:15 — with GitHub Actions Inactive
@jamiebenstead
jamiebenstead temporarily deployed to previews/1217/merge June 16, 2025 14:15 — with GitHub Actions Inactive
@maxelkins

Copy link
Copy Markdown
Contributor

@jamiebenstead

Shall we make the space on the side the same? i.e. make the right space (right) same as the left space (green).

Screenshot 2025-06-16 at 15 27 32

We might wanna drop the size of the icon down a little bit too to better match the smaller text? Might be too small when I see it but hard to say without trying it.

@maxelkins
maxelkins temporarily deployed to previews/1217/merge June 16, 2025 15:35 — with GitHub Actions Inactive
@jamiebenstead
jamiebenstead temporarily deployed to previews/1217/merge June 16, 2025 15:36 — with GitHub Actions Inactive
@jamiebenstead
jamiebenstead temporarily deployed to previews/1217/merge June 16, 2025 15:47 — with GitHub Actions Inactive
@adrian-rpf
adrian-rpf self-requested a review June 17, 2025 14:51

@adrian-rpf adrian-rpf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Straight forward style changes.

What browser testing has been done?

@adrian-rpf adrian-rpf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with @jamiebenstead that he test around multiple viewport sizes. Big and small

@jamiebenstead
jamiebenstead merged commit e869bc1 into main Jun 18, 2025
8 checks passed
@jamiebenstead
jamiebenstead deleted the fix-status-bar-overflow-on-mobile branch June 18, 2025 09:11
@jamiebenstead jamiebenstead mentioned this pull request Jul 22, 2025
jamiebenstead added a commit that referenced this pull request Jul 22, 2025
## [0.30.2] - 2025-07-22

### Fixed

- Styling issue preventing scrolling in the sidebar (#1216)
- Styling issue on status bar on mobile (#1217)
- Change tab `block-size` to `min-block-size` to allow for height
increase when text wraps (#1219)
- Changed `SkulptRunner.jsx` implementation of hiding elements to use
`display: none` rather than `block-size: 0` (#1219)
- Enabled `hyphens: auto` globally (with exceptions) to prevent overflow
with longer words (#1215)
- Removed fixed size from `ProjectBar` to prevent overflow when text
wraps (#1221)
- Added missing translation strings (#1222)
- Changed `colour_raw` to now correctly return a 4-tuple (R, G, B,
Clear) in simulation

### Changed

- Improved status bar styling (#1221)
- Added horizontal scrollbar to editor (#1228)
- Add theme for scrollbars (#1233)
jamiebenstead added a commit that referenced this pull request Jul 28, 2025
## [0.30.2] - 2025-07-22

### Fixed

- Styling issue preventing scrolling in the sidebar (#1216)
- Styling issue on status bar on mobile (#1217)
- Change tab `block-size` to `min-block-size` to allow for height
increase when text wraps (#1219)
- Changed `SkulptRunner.jsx` implementation of hiding elements to use
`display: none` rather than `block-size: 0` (#1219)
- Enabled `hyphens: auto` globally (with exceptions) to prevent overflow
with longer words (#1215)
- Removed fixed size from `ProjectBar` to prevent overflow when text
wraps (#1221)
- Added missing translation strings (#1222)
- Changed `colour_raw` to now correctly return a 4-tuple (R, G, B,
Clear) in simulation

### Changed

- Improved status bar styling (#1221)
- Added horizontal scrollbar to editor (#1228)
- Add theme for scrollbars (#1233)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants